Repository navigation
Test JDK 27 instead of 26 - #13438
Merged
Merged
Conversation
JDK 26 is out of support now that 27 is released. Spotless is skipped on the JDK 27 jobs only: palantir-java-format crashes there until palantir/palantir-java-format#1786 is released.
slachiewicz
marked this pull request as ready for review
October 12, 2026 12:25
gnodet-bot
approved these changes
Oct 12, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. Clean JDK 26→27 bump — JDK 26 is now out of support. The spotless skip is correctly scoped to JDK 27 only in both jobs that invoke the verify/install lifecycle (which is where spotless:check binds), and the inline comment calls out the upstream issue for removal tracking. No findings.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Comment on lines
+222
to
+223
| # palantir-java-format crashes on JDK 27 (palantir/palantir-java-format#1786); drop the skip once a fixed release is in maven-parent | ||
| run: mvn verify -Papache-release -Dgpg.skip=true -e -B -V ${{ matrix.java == '27' && '-Dspotless.skip=true' || '' }} |
Member
There was a problem hiding this comment.
I would like to see such switch in project pom, eg in profile
We can use also JDK 27 at local machine
Member
|
build not finished ... so why merged ... |
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDK 26 is out of support now that 27 is released, so the JDK 26 jobs test 27 instead. Spotless is skipped on the JDK 27 jobs only: palantir-java-format crashes there (
NoSuchFieldErrorforJCCompilationUnit.endPositions, palantir/palantir-java-format#1786, not yet released); the other JDKs keep checking formatting. Drop the skip once maven-parent ships a fixed palantir-java-format.Verified locally on Temurin 27+35 (aarch64) with Maven 4.0.0-rc-7 and
-Dspotless.skip:mvn install -DskipTestsandmvn testpass, 3281 unit tests, 0 failures. Core ITs not run locally.