Repository navigation
fix(frontend): replace vendor logos in operator icons with typographic icons - #8999
Conversation
…c icons Thirteen operator icons were other organisations' logos (Twitter, Reddit, PostgreSQL, MySQL, Hugging Face, the Python logo), a photo of an iris, or stock artwork, with no recorded source or licence (apache#8982). Replace them with project-made typographic icons in the style of the UDF icons from apache#5686: a large hero word with an optional gray descriptor on a 1024x1024 transparent canvas. The text is rendered with Aileron Regular (CC0), the font bundled with Pillow. File names are unchanged.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Automated Reviewer SuggestionsBased on the
|
Yicong-Huang
added
release/v1.3
Backport auto-label reportThis
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8999 +/- ##
============================================
+ Coverage 91.98% 93.14% +1.15%
+ Complexity 5084 5004 -80
============================================
Files 1281 1274 -7
Lines 55812 61921 +6109
Branches 7076 8654 +1578
============================================
+ Hits 51340 57677 +6337
+ Misses 2732 2495 -237
- Partials 1740 1749 +9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xuang7
left a comment
xuang7
left a comment
There was a problem hiding this comment.
LGTM! All 13 replacements are text-based and contain no third-party branding. All 13 replacements are typographic with no third-party marks, and since only the rendered PNGs are committed (Aileron is CC0 anyway), no LICENSE entry is needed.
One minor suggestion: could we simply remove the Twitter-related images, since the service appears to be deprecated? See #4463.
…h release/v1.2 does not have) The cherry-pick added frontend/src/assets/operator_images/HuggingFace.png, which release/v1.2 never had and nothing there refers to. The other 12 icons are as in #8999.
What changes were proposed in this PR?
Per #8982, thirteen operator icons under
frontend/src/assets/operator_images/were other organisations' logos (Twitter, Reddit, PostgreSQL, MySQL, Hugging Face, the Python logo), a photo of an iris, or stock-looking artwork, with no recorded source or licence. None of them has a licence that lets an Apache source release redistribute it, so this replaces them with project-made icons.The new icons follow the UDF icons from #5686: a large hero word with an optional gray descriptor on a 1024×1024 transparent canvas, so they match
Py,RandJavaon the canvas. They were drawn with Pillow, and the text uses Aileron Regular (CC0), the font bundled with Pillow, so noLICENSEentry is needed. File names are unchanged, so theassets/operator_images/<operatorType>.pnglookup still finds them.JavaUDF.pngonmainis already the project-made icon from #5686, so it isn't touched. Onrelease/v1.2it is still the Java logo, because #5686 wasn't backported, and that branch has noHuggingFace.png, so the v1.2 backport needs both adjusted.Any related issues, documentation, discussions?
Part of #8982; its Jupyter item is #8997 and #8998. Part of #8800.
How was this PR tested?
Asset swap only, with no code change. Previewed the icons at the 35 px size the workflow canvas draws them at, and checked that the commit applies cleanly to
release/v1.3.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-5-5)