Repository navigation
fix(frontend, v1.2): replace vendor logos in operator icons with typographic icons - #9192
Open
github-actions[bot] wants to merge 2 commits into
Open
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…c icons (#8999) ### What changes were proposed in this PR? Per #8982, thirteen operator icons under `frontend/src/assets/operator_images/` were other organisations' logos (Twitter, Reddit, PostgreSQL, MySQL, Hugging Face, the Python logo), a photo of an iris, or stock-looking artwork, with no recorded source or licence. None of them has a licence that lets an Apache source release redistribute it, so this replaces them with project-made icons. The new icons follow the UDF icons from #5686: a large hero word with an optional gray descriptor on a 1024×1024 transparent canvas, so they match `Py`, `R` and `Java` on the canvas. They were drawn with Pillow, and the text uses Aileron Regular (CC0), the font bundled with Pillow, so no `LICENSE` entry is needed. File names are unchanged, so the `assets/operator_images/<operatorType>.png` lookup still finds them. `JavaUDF.png` on `main` is already the project-made icon from #5686, so it isn't touched. On `release/v1.2` it is still the Java logo, because #5686 wasn't backported, and that branch has no `HuggingFace.png`, so the v1.2 backport needs both adjusted. ### Any related issues, documentation, discussions? Part of #8982; its Jupyter item is #8997 and #8998. Part of #8800. ### How was this PR tested? Asset swap only, with no code change. Previewed the icons at the 35 px size the workflow canvas draws them at, and checked that the commit applies cleanly to `release/v1.3`. ### Was this PR authored or co-authored using generative AI tooling? (backported from commit 1aa7e2a) Generated-by: Claude Code (claude-opus-5-5)
Contributor
Author
|
The cherry-pick conflicted and was committed with conflict markers. Resolve the conflicts on this branch, then mark this PR ready for review. Conflicting files:
|
…h release/v1.2 does not have) The cherry-pick added frontend/src/assets/operator_images/HuggingFace.png, which release/v1.2 never had and nothing there refers to. The other 12 icons are as in #8999.
mengw15
marked this pull request as ready for review
October 27, 2026 22:50
Contributor
Author
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.2 #9192 +/- ##
==================================================
- Coverage 53.48% 53.45% -0.04%
Complexity 2564 2564
==================================================
Files 1078 1078
Lines 42359 42359
Branches 4563 4563
==================================================
- Hits 22655 22642 -13
- Misses 18386 18400 +14
+ Partials 1318 1317 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Automated backport of #8999 to
release/v1.2.Source: 1aa7e2a · automation run
Any related issues, documentation, discussions?
Backport of #8999.
How was this PR tested?
Release-branch CI runs on this branch once the conflicts are resolved and this PR is marked ready for review.
Was this PR authored or co-authored using generative AI tooling?
No.