Skip to content

refactor(frontend): drop dead members in execution history - #9194

Merged
kunwp1 merged 1 commit into
apache:mainfrom
aglinxinyuan:refactor/frontend-exec-history-cleanup
Oct 28, 2026
Merged

kunwp1 merged 1 commit into
apache:mainfrom
aglinxinyuan:refactor/frontend-exec-history-cleanup

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Removes dead members and unused service injections from WorkflowExecutionHistoryComponent and its test suite:

  1. workflow-execution-history.component.ts:
    • Drops unused WorkflowActionService constructor injection and import.
    • Drops currentlyHoveredExecution field which is never set (its hover handlers were dropped previously).
  2. workflow-execution-history.component.html:
    • Simplifies the bookmark star icon's [nzTheme] condition to row.bookmarked ? 'fill' : 'outline'.
  3. workflow-execution-history.component.spec.ts:
    • Drops OperatorMetadataService and StubOperatorMetadataService imports and provider, which were only needed to instantiate the unused WorkflowActionService.

+1/-9 lines. Pure cleanup with no behavior change.

Any related issues, documentation, discussions?

Closes #9193.

How was this PR tested?

  • Prettier check passed:
    npx prettier --check src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.html src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.spec.ts
  • TypeScript compilation check (src/tsconfig.spec.json): zero errors in modified files.
  • Verified 0 callers repo-wide for currentlyHoveredExecution.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Antigravity (Claude Opus 5.5)

@aglinxinyuan aglinxinyuan added refactor Refactor the code frontend Changes related to the frontend GUI labels Oct 27, 2026
Copilot AI balanced review requested due to automatic review settings October 27, 2026 23:12
@aglinxinyuan aglinxinyuan added the frontend Changes related to the frontend GUI label Oct 27, 2026
@aglinxinyuan aglinxinyuan self-assigned this Oct 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Neilk1021, @mengw15, @Yicong-Huang
    You can notify them by mentioning @Neilk1021, @mengw15, @Yicong-Huang in a comment.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.98%. Comparing base (1aa7e2a) to head (b272bc7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9194      +/-   ##
============================================
- Coverage     91.98%   91.98%   -0.01%     
  Complexity     5084     5084              
============================================
  Files          1281     1281              
  Lines         55812    55810       -2     
  Branches       7076     7076              
============================================
- Hits          51339    51336       -3     
  Misses         2733     2733              
- Partials       1740     1741       +1     
Flag Coverage Δ *Carryforward flag
access-control-service 77.44% <ø> (ø) Carriedforward from 1aa7e2a
agent-service 99.16% <ø> (ø) Carriedforward from 1aa7e2a
amber 86.42% <ø> (ø) Carriedforward from 1aa7e2a
computing-unit-managing-service 63.52% <ø> (ø) Carriedforward from 1aa7e2a
config-service 87.50% <ø> (ø) Carriedforward from 1aa7e2a
file-service 82.29% <ø> (ø) Carriedforward from 1aa7e2a
frontend 96.53% <100.00%> (-0.01%) ⬇️
notebook-migration-service 83.77% <ø> (ø) Carriedforward from 1aa7e2a
pyamber 98.54% <ø> (ø) Carriedforward from 1aa7e2a
workflow-compiling-service 74.25% <ø> (ø) Carriedforward from 1aa7e2a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunwp1 kunwp1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunwp1
kunwp1 enabled auto-merge October 28, 2026 00:16
@kunwp1
kunwp1 added this pull request to the merge queue Oct 28, 2026
Merged via the queue into apache:main with commit 39f0e02 Oct 28, 2026
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up dead service injection, styles, and hover field in WorkflowExecutionHistoryComponent

4 participants