Skip to content

refactor(frontend): drop dead members in execution history #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunwp1 merged 1 commit into from
Oct 28, 2026
+1 −9
Merged

refactor(frontend): drop dead members in execution history #9194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...er/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
<td nzEllipsis>
<i
(click)="onBookmarkToggle(row)"
[nzTheme]="(row.bookmarked || currentlyHoveredExecution === row) ? 'fill' : 'outline'"
[nzTheme]="row.bookmarked ? 'fill' : 'outline'"
class="bookmark-icon"
nz-icon
nzType="star"></i>
Expand Down
5 changes: 0 additions & 5 deletions ...user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ import { WorkflowRuntimeStatistics } from "../../../../type/workflow-runtime-sta
import { NotificationService } from "../../../../../common/service/notification/notification.service";
import { UserService } from "../../../../../common/service/user/user.service";
import { StubUserService } from "../../../../../common/service/user/stub-user.service";
import { OperatorMetadataService } from "../../../../../workspace/service/operator-metadata/operator-metadata.service";
import { StubOperatorMetadataService } from "../../../../../workspace/service/operator-metadata/stub-operator-metadata.service";
import { commonTestProviders } from "../../../../../common/testing/test-utils";
import { DebugElement } from "@angular/core";
import { By } from "@angular/platform-browser";
Expand Down Expand Up @@ -164,9 +162,6 @@ describe("WorkflowExecutionHistoryComponent", () => {
providers: [
{ provide: WorkflowExecutionsService, useValue: executionsService },
{ provide: NotificationService, useValue: notificationService },
// WorkflowActionService is injected (though unused by the component logic);
// the stub metadata service lets the real one instantiate, as in menu.component.spec.ts.
{ provide: OperatorMetadataService, useClass: StubOperatorMetadataService },
// UserService backs the <texera-user-avatar> child in each table row.
{ provide: UserService, useClass: StubUserService },
{ provide: NZ_MODAL_DATA, useValue: options.modalData === null ? null : options.modalData ?? { wid: 1 } },
Expand Down
3 changes: 0 additions & 3 deletions ...user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { EXECUTION_STATUS_CODE, WorkflowExecutionsEntry } from "../../../../type
import { WorkflowExecutionsService } from "../../../../service/user/workflow-executions/workflow-executions.service";
import { ExecutionState } from "../../../../../workspace/types/execute-workflow.interface";
import { NotificationService } from "../../../../../common/service/notification/notification.service";
import { WorkflowActionService } from "../../../../../workspace/service/workflow-graph/model/workflow-action.service";
import Fuse from "fuse.js";
import { ceil } from "lodash";
import { NZ_MODAL_DATA, NzModalRef, NzModalService } from "ng-zorro-antd/modal";
Expand Down Expand Up @@ -118,7 +117,6 @@ export class WorkflowExecutionHistoryComponent implements OnInit, AfterViewInit
public processTimeBarChart = WorkflowExecutionHistoryComponent.PROCESS_TIME_BAR_CHART;
public workflowExecutionsDisplayedList: WorkflowExecutionsEntry[] | undefined;
public workflowExecutionsIsEditingName: number[] = [];
public currentlyHoveredExecution: WorkflowExecutionsEntry | undefined;
public executionsTableHeaders: string[] = [
"",
"Avatar",
Expand Down Expand Up @@ -201,7 +199,6 @@ export class WorkflowExecutionHistoryComponent implements OnInit, AfterViewInit
private workflowExecutionsService: WorkflowExecutionsService,
private notificationService: NotificationService,
private runtimeStatisticsModal: NzModalService,
private workflowActionService: WorkflowActionService,
private route: ActivatedRoute,
@Optional() @Inject(NZ_MODAL_DATA) private modalData: any
) {}
Expand Down
Loading