chore(proto): drop vendored Go/Python client stubs#728
Merged
Conversation
Go and Python client stubs now live in dedicated, BSR-driven packages (authorizer-proto-go, authorizer-proto-python) consumed as real versioned dependencies, so the vendored gen/go-client and gen/python trees are dead weight and a fresh source of drift. - Remove gen/go-client and gen/python. - buf.gen.clients.yaml: drop the go/python plugins + go_package_prefix override; keep only the TS (protobuf-es) plugin that authorizer-js consumes. - Makefile/buf.yml: retarget the client-stub staleness gate to gen/ts only. gen/ts stays: authorizer-js speaks graphql/rest (not gRPC) and its surfaces are snake_case, so it keeps hand-typed transport but reuses these message shapes. Merge AFTER authorizer-go#23 and authorizer-py#9 land and authorizer-proto is published to PyPI — until then these trees are the SDKs' fallback.
buf.gen.clients.yaml dropped its managed-mode go_package_prefix override (no longer needed - the Go/Python client generation blocks it applied to are gone) but gen/ts itself was never regenerated under the resulting config, leaving stale Go-specific metadata baked into its embedded descriptors. make proto-check-clients now passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go and Python client stubs now live in dedicated, BSR-driven packages consumed as real versioned dependencies —
authorizer-proto-goandauthorizer-proto-python— so the vendoredgen/go-clientandgen/pythontrees in this repo are now dead weight and a fresh source of drift (the very drift behind #726). This removes them.Merge after authorizerdev/authorizer-go#23 and authorizerdev/authorizer-py#9 land and
authorizer-protois published to PyPI. Until the SDKs cut over, these trees are their fallback.Changes
gen/go-client/andgen/python/.proto/buf.gen.clients.yaml: drop the go/python plugins + the now-deadgo_package_prefixoverride; keep only the TS (protobuf-es) plugin.Makefile+.github/workflows/buf.yml: retarget the client-stub staleness gate (proto-check-clients) togen/tsonly.Why gen/ts stays
authorizer-jsspeaks GraphQL/REST (browsers can't do raw gRPC) and its public API is deliberately snake_case, while protobuf-es generates camelCase TS property names (not configurable). So authorizer-js keeps hand-typed transport and only reuses these generated message shapes — it is intentionally out of scope for the proto-package migration.Not fixed here (pre-existing, unrelated)
gen/tshas a small pre-existing drift vs current BSR googleapis (google/api descriptor option bytes). It is orthogonal to this change and left untouched to keep the diff surgical.Not self-merging — structural/CI change, leaving for review.