Skip to content

chore(proto): drop vendored Go/Python client stubs #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakhansamani merged 2 commits into from
Jul 24, 2026
Merged

chore(proto): drop vendored Go/Python client stubs #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b93f1af
chore(proto): drop vendored Go/Python client stubs
lakhansamani Jul 24, 2026
f1e8972
chore(proto): regenerate gen/ts under the trimmed client-stub template
lakhansamani Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/buf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ jobs:
# Regenerate gen/ from proto/ and fail if the committed output is stale.
- name: Verify generated protobuf output
run: make proto-check
# Same gate for the client-SDK stubs (gen/go-client, gen/python, gen/ts)
# vendored into the standalone SDK repos — these use a separate template
# (buf.gen.clients.yaml) that proto-check does not touch.
# Same gate for the vendored TS stubs (gen/ts, consumed by authorizer-js)
# — these use a separate template (buf.gen.clients.yaml) that proto-check
# does not touch. Go/Python stubs moved to dedicated proto packages.
- name: Verify generated client SDK stubs
run: make proto-check-clients
# Compare against the published module so a PR that would break
Expand Down
11 changes: 6 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,17 @@ proto-check: proto-gen
@git diff --exit-code -- gen/ || (echo "gen/ is stale; run make proto-gen and commit the result" && exit 1)

# Client-SDK stub generation (separate template from proto-gen above). Outputs
# gen/go-client, gen/python and gen/ts, which are vendored into the standalone
# SDK repos (authorizer-go, authorizer-python, authorizer-js). NOT covered by
# proto-gen/proto-check, so they need their own regenerate + staleness gate.
# gen/ts, vendored into authorizer-js. Go and Python stubs are no longer
# generated here — they live in the dedicated authorizer-proto-go /
# authorizer-proto-python packages (BSR-driven, consumed as real dependencies).
# NOT covered by proto-gen/proto-check, so gen/ts needs its own staleness gate.
proto-gen-clients: proto-tools
cd proto && buf dep update && buf generate --template buf.gen.clients.yaml --include-imports

# Fail when proto sources changed but the vendored client stubs were not
# Fail when proto sources changed but the vendored TS stubs were not
# regenerated and committed.
proto-check-clients: proto-gen-clients
@git diff --exit-code -- gen/go-client gen/python gen/ts || (echo "client SDK stubs are stale; run make proto-gen-clients and commit the result" && exit 1)
@git diff --exit-code -- gen/ts || (echo "client SDK stubs (gen/ts) are stale; run make proto-gen-clients and commit the result" && exit 1)

# ----------------------------------------------------------------------------
# Formatting & linting (Go + TypeScript). `make fmt` before committing,
Expand Down
Loading
Loading