test: isolate offline suite from ambient SubLLM - #107
Conversation
There was a problem hiding this comment.
Deterministic Validator approval for exact head 8f5bc6c405163066dcf81603c91d13bbd5a63add.
Ticket: ticket-090
Correlation ID: todo2code-pr-107-ticket-090
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The PR sets T2C_USE_SUBLLM=false on the default npm test command to make offline tests independent of ambient SubLLM credentials, plus ticket-090 governance/evidence artifacts. The change is minimal, within allowedPaths, and production routing is unchanged.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-090-1342
TICKET ticket-090
HEAD_SHA 8f5bc6c405163066dcf81603c91d13bbd5a63add
CORRELATION_ID todo2code-pr-107-ticket-090
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance=SKIPPING","Live OpenRouter contract (opt-in)=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"There was a problem hiding this comment.
Deterministic Validator approval for exact head 8f5bc6c405163066dcf81603c91d13bbd5a63add.
Ticket: ticket-090
Correlation ID: todo2code-pr-107-ticket-090
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Small, well-scoped change pinning the default test command to the compatibility fixture transport via T2C_USE_SUBLLM=false, plus ticket-090 governance/evidence files. No production routing changes. All visible checks pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-090-3958
TICKET ticket-090
HEAD_SHA 8f5bc6c405163066dcf81603c91d13bbd5a63add
CORRELATION_ID todo2code-pr-107-ticket-090
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Java adapter (JDK 17 required)=PASS","verify=PASS","Live OpenRouter contract (opt-in)=SKIPPING","governance / governance / enforce=PASS","governance=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Replaces #106 with the required plan-first commit history.
Summary
Validation
npm run buildnpm test./project/governance-check.shgit diff --checkTicket:
ticket-090