Add Data Maker dataset-driven runs - #635
Draft
HappyDevs1 wants to merge 2 commits into
Draft
HappyDevs1 wants to merge 2 commits into
HappyDevs1 wants to merge 2 commits into
Conversation
HappyDevs1
added this pull request to stack #648
September 22, 2026 05:07
CI denies clippy::unwrap_used workspace-wide (-D warnings). The dataset-run summary re-parsed its own just-built report JSON with two `.unwrap()` calls where the typed `results: Vec<DataRowResult>` was already in scope; use it directly instead. Test-only `.unwrap()`/`.unwrap_err()` calls in data.rs become `.expect()`/`.expect_err()` with a message, matching the rest of the suite. Also document `run --data PATH`, which every_visible_cli_flag_is_mentioned_in_the_docs flagged as shipped but unwritten.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Stack
This draft is based on feat/cli-doctor-json so the existing doctor work is not duplicated in this PR.
Desktop companion: https://github.com/automators-com/flowproof-desktop/pull/40