Skip to content

Introduce pipeline messages and checked routing acceptance - #174

Merged
Stephen Belanger (Qard) merged 9 commits into
mainfrom
pipeline/01-stage-contracts
Oct 19, 2026
Merged

Stephen Belanger (Qard) merged 9 commits into
mainfrom
pipeline/01-stage-contracts

Conversation

@Qard

@Qard Stephen Belanger (Qard) commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Stage extraction and completion-preserving messages establish the contracts for the recoverable pipeline. Delivery<T> retains its completion obligation through mapping and forwarding; terminal extraction confirms event checkpoint persistence. Plugin outcomes describe results without naming successor stages.

Braintrust sinks enable checked delivery and own a queue per routing branch, preventing a rejected sibling batch from poisoning another route's flush. Rejected flushes invalidate the actor's contiguous checkpoint boundary so consumed failed batches remain eligible for journal replay. Deferred delivery and checkpoint-write failures can still complete later. This layer preserves event replay; automatic recovery comes in subsequent layers.

The SDK pin uses the merged braintrust-sdk-rust#106 commit f2216fa0ceee132e02f1392c0e5af89ae762e9c8, with the matching Cargo.lock revision. Unused channel-port traits are deferred to the next layer; dead-code allowances cover only individual methods and a field.

Stacked on #194, which isolates doctor tests from installed settings, and main at 98051a5, including production unwrap/expect bans, security dependency updates, and all-span provenance. Main's expanded provenance coverage replaces the former root-only sink test.

Pipeline layer 1 of 9; base: #194.

Validation at 3514528: all 513 tests pass in the locked all-feature Rust suite without exclusions or environment overrides; five live-agent tests remain normally ignored. Strict all-target/all-feature Clippy, formatting, and diff checks pass. Restacked on #194 at b2c24be; fresh remote CI is pending.

SDK dependency update at 2c4e7be: strict Clippy, formatting, and diff checks pass. The local full-suite attempt stopped at stalled_initialize_keeps_cursor_tool_observation_fail_open; further validation is delegated to CI as requested.

@Qard
Stephen Belanger (Qard) changed the base branch from main to fix/cursor-env-contract October 13, 2026 15:47
@Qard
Stephen Belanger (Qard) changed the base branch from fix/cursor-env-contract to main October 13, 2026 16:04
@Qard
Stephen Belanger (Qard) marked this pull request as ready for review October 13, 2026 16:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T16:15:23.558614Z b6119ce Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6119ce0c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread bt-daemon/src/sink/braintrust.rs
@Qard
Stephen Belanger (Qard) changed the base branch from main to fix/isolate-doctor-test-settings October 16, 2026 14:19
Base automatically changed from fix/isolate-doctor-test-settings to main October 19, 2026 09:24
@AbhiPrasad

Copy link
Copy Markdown
Member

we should make sure we bump rust sdk dep before merging in all these prs

@Qard
Stephen Belanger (Qard) merged commit 2fc47d5 into main Oct 19, 2026
22 checks passed
@Qard
Stephen Belanger (Qard) deleted the pipeline/01-stage-contracts branch October 19, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants