Repository navigation
Consolidate durable subscription lifecycle and retention - #188
Merged
Merged
Conversation
Stephen Belanger (Qard)
force-pushed
the
pipeline/07-lifecycle-cleanup
branch
from
October 14, 2026 02:27
fe50517 to
41ba2bb
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/06-recovery-transitions
branch
from
October 14, 2026 02:27
066c394 to
c1fc4d9
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/07-lifecycle-cleanup
branch
from
October 14, 2026 05:15
21b30df to
6b5fe9e
Compare
Stephen Belanger (Qard)
marked this pull request as ready for review
October 14, 2026 05:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b5fe9ea0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
force-pushed
the
pipeline/07-lifecycle-cleanup
branch
3 times, most recently
from
October 14, 2026 13:32
829a322 to
b0373a5
Compare
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
October 14, 2026 14:58
Stephen Belanger (Qard)
force-pushed
the
pipeline/06-recovery-transitions
branch
from
October 16, 2026 16:11
76cbe09 to
5aee065
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/07-lifecycle-cleanup
branch
from
October 16, 2026 16:24
928e039 to
9bdc594
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 19, 2026
Stephen Belanger (Qard)
force-pushed
the
pipeline/06-recovery-transitions
branch
from
October 19, 2026 18:49
5aee065 to
8b9e7a8
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/07-lifecycle-cleanup
branch
from
October 19, 2026 19:07
9bdc594 to
d689455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Durable heads restore subscriptions even when their canonical route is absent from captured envelopes. Routing-only startup does not synthesize native controls. Retirement releases route observers; credential refresh updates the existing lease cache, and backend/organization bindings prevent redirecting an acknowledged head after restart.
Retention collects only expired, inactive partitions whose source is caught up and whose registered and captured routes have no unresolved obligations. Retained inputs protect referenced transcript mirrors and correlation state. Ledger loading and correlation-write failures retain work instead of bypassing persistence. Source shutdown closes shared SQLite connections after serialized task shutdown so cancelled blocking reads cannot retain Windows file handles.
Preserves #187's append-only ledger completion recovery and all-span journaled provenance. Lifecycle bookkeeping follows main's non-poisoning mutex policy; missing auth providers and route-encoding failures use explicit handling under the production panic bans. Updated ledger fixtures handle fallible initialization without weakening inherited completion tests.
Stacked on #187 (
5aee065). The checked-delivery SDK remains pinned in #174. InputPort and submission-stage isolation remain in later layers.Validation at
9bdc594: all 541 tests pass in the locked all-feature Rust suite without exclusions or environment overrides; five live-agent tests remain normally ignored. Coverage includes retention obligations and referenced files, schema migration, backend pinning, dormant subscription recovery, credential refresh, cancelled-read storage closure, checked-delivery rejection, provenance, and ledger/head completion recovery. Strict all-target/all-feature Clippy, formatting, and diff checks pass. Fresh remote CI is pending.Pipeline layer 7 of 9; base: #187.