Repository navigation
Keep journal replay behind the shared InputPort contract - #192
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Stephen Belanger (Qard)
changed the title
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
October 16, 2026 13:49
Stephen Belanger (Qard)
force-pushed
the
pipeline/07-lifecycle-cleanup
branch
from
October 16, 2026 16:24
928e039 to
9bdc594
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/08-span-journal-ports
branch
from
October 16, 2026 16:51
9090075 to
7a3f6ff
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 19, 2026
Stephen Belanger (Qard)
force-pushed
the
pipeline/07-lifecycle-cleanup
branch
from
October 19, 2026 19:07
9bdc594 to
d689455
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/08-span-journal-ports
branch
from
October 19, 2026 19:15
7a3f6ff to
618f178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route processing consumes the existing
InputPortand retains each delivery's original completion handle until checked sink delivery finishes. The journal adapter owns abandoned-input replay, persisted recovery waits, route binding, and head advancement. Source progress and flush barriers stay in session wiring, so the consumer has no journal or cursor API. This removesRouteInputPortand consumer-created prefix acknowledgements.The consumer compares typed failure values without serializing persistence records; encoding stays with the source adapter. Bookkeeping follows main's mutex and panic-ban policies. Session wiring passes the existing observer key instead of serializing the route again. Inherited ledger completion recovery remains covered through the shared port.
Based on main at
601dcfd, including merged #188. Validation at7a3f6ff: all 544 tests pass in the locked all-feature Rust suite without exclusions or environment overrides; five live-agent tests remain normally ignored. Coverage includes plain channels, journal replay forwarded through an ordinary channel, abandoned/cancelled receives, restart and plugin-edit recovery, deferred multi-batch acknowledgements, and ledger/head retry without resubmission. Strict all-target/all-feature Clippy, formatting, and diff checks pass. Fresh remote CI is pending.Pipeline layer 8; base: main (includes #188).
Rebased at
618f178: all four commits retain identical patches (git range-diff); diff checks pass. Tests are left to fresh CI as requested.