Repository navigation
Isolate routing submission stage - #193
Merged
Stephen Belanger (Qard) merged 4 commits intoOct 19, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Stephen Belanger (Qard)
force-pushed
the
pipeline/09-routing-stage-handlers
branch
2 times, most recently
from
October 15, 2026 15:39
2950d15 to
72b6b40
Compare
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
October 16, 2026 13:54
Stephen Belanger (Qard)
force-pushed
the
pipeline/08-span-journal-ports
branch
from
October 16, 2026 16:51
9090075 to
7a3f6ff
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/09-routing-stage-handlers
branch
from
October 16, 2026 16:56
72b6b40 to
7c52017
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 19, 2026
Stephen Belanger (Qard)
force-pushed
the
pipeline/08-span-journal-ports
branch
from
October 19, 2026 19:15
7a3f6ff to
618f178
Compare
Stephen Belanger (Qard)
force-pushed
the
pipeline/09-routing-stage-handlers
branch
from
October 19, 2026 19:25
f7b9c20 to
a4ad11f
Compare
Stephen Belanger (Qard)
deleted the
pipeline/09-routing-stage-handlers
branch
October 19, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoutingSink remains the bounded actor and wiring point while plugin execution and sink submission use separate stage handlers with private state. Submission owns configuration, emit/flush, delivery status, and SDK-specific failure classification. The container maps typed stage outcomes into shared retry conditions; generic recovery does not inspect SDK or plugin errors. Empty filtered batches retain their existing no-op behavior.
Preserves #192's shared InputPort contract, original delivery receipts, and typed failure comparisons. Completion recovery checks the error cause chain so submission-stage wrappers cannot turn a post-acceptance ledger failure into a batch resubmission. The inherited regression reproduced two submissions before this fix and exactly one afterward.
Based on main at
4520392, including merged #192. Validation at7c52017: all 544 tests pass in the locked all-feature Rust suite without exclusions or environment overrides; five live-agent tests remain normally ignored. Strict all-target/all-feature Clippy, formatting, and diff checks pass. Fresh remote CI is pending.Pipeline layer 9; base: main (includes #192).
Rebased at
a4ad11f: all four commits retain identical patches (git range-diff); diff checks pass. Tests are left to fresh CI as requested.