Conversation
…ll reaches the kernel `scripts/mutation/ownership.test.ts` fails on today's `main`, so `check:affected` stops at its `mutation-model` step for any change touching a lane file. The derivation it guards is intact — 147 tests own `scroll-edge-state`, including every test that reaches it through `src/daemon/scroll-runtime.ts`. What went stale is the example: the gesture unit test's import closure no longer reaches the scroll runtime at all, so asserting that it owns the kernel asserts something the graph no longer contains. `src/daemon/__tests__/scroll-runtime.test.ts` sits one import away from `scroll-edge-state.ts` and never mentions it, which is the omission the assertion exists to catch.
Size Report
Startup median (7 runs, lower is better):
|
|
Reviewed at 5a8ba8e. The change is correct: This PR now conflicts with main. #2613 (208e3d3) already fixed the same assertion by moving the example to Smoke Tests fails in the live iOS scenario (the long-press element did not become visible after scrolling). This PR changes only |
|
Closed: |
Summary
pnpm check:affectedstops at itsmutation-modelstep on today'smain:scripts/mutation/ownership.test.tsasserts thatsrc/commands/interaction/runtime/gestures.test.tsindirectly owns thescroll-edge-statekernel, and the gesture test's import closure no longer reaches the scroll runtime at all. Any change touching a lane file runs that step, so this blocks more than it looks like it does — an edit to.github/workflows/ios.ymltrips it.The derivation it guards is intact: 147 tests own
scroll-edge-state, every one of them reaching it throughsrc/daemon/scroll-runtime.tsrather than naming it. What is stale is which test is used as the example, so the fix moves the example rather than relaxing the assertion.src/daemon/__tests__/scroll-runtime.test.tssits one import away fromscroll-edge-state.tsand never mentions it, which is exactly the omission the assertion exists to catch; thekernel-errorshalf of the test is unchanged.One file, +6/-6, no runtime code.
Validation
5fb2860119before touching anything:node --test scripts/mutation/ownership.test.ts→ 4 pass, 1 fail (a kernel is owned by tests that reach it indirectly).5a8ba8e81e:node --test scripts/mutation/*.test.ts→ 40 pass, 0 fail.pnpm check:affected --rungreen at this head, includingmutation-model,gate-manifest,depgraphandtmpdir-leaks.