Skip to content

test(scripts): keep the indirect-ownership example on a test that still reaches the kernel #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thymikee wants to merge 1 commit into from
Closed

test(scripts): keep the indirect-ownership example on a test that still reaches the kernel #2637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/mutation/ownership.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,18 @@ test('a kernel is owned by the mirrored test that imports it directly', () => {
);
});

// The omission that hand-listed ownership could not see: this test asserts over
// normalizeError without importing packages/kernel/src/errors.ts itself.
// The omission that hand-listed ownership could not see: neither test below names the kernel source
// it reaches. `daemon-error.test.ts` asserts over `normalizeError` without importing
// packages/kernel/src/errors.ts, and the scroll runtime test never mentions scroll-edge-state.
test('a kernel is owned by tests that reach it indirectly', () => {
const deriver = ownershipDeriver(repoRoot);
assert.ok(
deriver.ownersOf('src/__tests__/daemon-error.test.ts').includes('kernel-errors'),
'daemon-error.test.ts exercises normalizeError but does not own kernel-errors',
);
assert.ok(
deriver
.ownersOf('src/commands/interaction/runtime/gestures.test.ts')
.includes('scroll-edge-state'),
deriver.ownersOf('src/daemon/__tests__/scroll-runtime.test.ts').includes('scroll-edge-state'),
'scroll-runtime.test.ts reaches scroll-edge-state through the daemon runtime, not by import',
);
});

Expand Down
Loading