Skip to content

fix: stop error notices when toggling Progress Properties and the Kanban helper - #228

Merged
chhoumann merged 2 commits into
masterfrom
fix/automator-error-notice
Oct 24, 2026
Merged

chhoumann merged 2 commits into
masterfrom
fix/automator-error-notice

Conversation

@chhoumann

@chhoumann chhoumann commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

Turn on Progress Properties, then turn on the Kanban Board Helper (or the reverse), and MetaEdit shows an error notice:

MetaEdit: (ERROR) a ProgressProperties automator is already attached.

Nothing is actually wrong. Every toggle calls toggleAutomators(), which reconciles both automators with the settings. The automator that was already on gets attached again, and attach() logged that as a warning.

  • OnFileModifyAutomatorManager.attach() now treats an already attached automator as a no-op.
  • The notice said (ERROR) because LogManager.logWarning called each logger's logError. Warnings now go to logWarning, so they read MetaEdit: (WARNING) ... and use console.warn. The only remaining warning is the Kanban helper's "'{property}' not found" notice.
  • The docs described that label as a known quirk in reference/notices.md, help/faq.md, and help/troubleshooting.md, and quoted (ERROR) in two Kanban pages. They're updated.
  • tests/obsidian-stub.ts gains a small debounce so the automator manager can load in unit tests.

Verification

  • Reproduced on master in Obsidian 1.14.4 (Linux, isolated obsidian-e2e vault) by clicking the two toggles in the settings tab. The notice above appears.
  • With this branch, the same clicks (Progress on, Kanban on, Progress off) show no notice, and the attached automators are ["KanbanHelper"], matching the settings.
  • New src/automators/onFileModifyAutomatorManager.test.ts: attaching the same type twice shows no notice, and log.logWarning reports (WARNING). Both fail on master's code.
  • pnpm run lint, pnpm run build, pnpm run test (361 passed).

Not changed: LogManager.logError still throws after logging. The Progress Properties catch block calls it, so a failed count update ends in an unhandled rejection after the notice. That's a separate fix.

Release impact: user-facing fix, no settings or API changes.


Note

Low Risk
Behavior change is limited to logging and idempotent automator attach; no write paths or settings schema changes.

Overview
Fixes spurious MetaEdit: (ERROR) popups when enabling Progress Properties and the Kanban Board Helper together, and makes real warnings show as (WARNING) instead of (ERROR).

OnFileModifyAutomatorManager.attach() now silently ignores duplicate automator types instead of calling log.logWarning, because toggleAutomators() re-attaches automators that are already on whenever another toggle changes.

LogManager.logWarning now fans out to each logger’s logWarning (not logError), so notices like missing Kanban properties or missing board files use the correct prefix and console.warn.

Adds unit tests for duplicate attach and warning formatting, a debounce stub in tests/obsidian-stub.ts for loading the automator manager in Vitest, and updates docs/FAQ/troubleshooting to drop the old “warnings labeled ERROR” quirk and quote (WARNING) for Kanban messages.

Reviewed by Cursor Bugbot for commit f654f5a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix error notices when toggling Progress Properties and the Kanban helper

  • LogManager.logWarning now calls each logger's warning handler instead of its error handler, so warnings no longer show the error prefix (logManager.ts)
  • OnFileModifyAutomatorManager.attach returns silently when the automator type is already attached, instead of logging a warning — settings reconciliation can attempt this (onFileModifyAutomatorManager.ts)
  • Updates website docs to reflect the warning prefix and removes the FAQ entry about mislabeled warnings
  • Adds tests for duplicate attachment, warning dispatch, and a debounce stub in the Obsidian test double
  • Behavioral Change: notice text for missing Kanban properties and boards changes from the MetaEdit: (ERROR) prefix to MetaEdit: (WARNING)

Macroscope summarized 8caa3a1.

…ban helper

Each toggle reconciles both automators with the settings, so the one that
was already on got attached again and attach() logged 'a ProgressProperties
automator is already attached.' Attaching an attached automator is now a
no-op.

The notice also read '(ERROR)' because LogManager.logWarning fanned out to
each logger's logError. Warnings now go to logWarning and read '(WARNING)'.
The docs that described that quirk are updated.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
metaedit-docs f654f5a Oct 24 2026, 02:48 PM

@chhoumann
chhoumann merged commit 6e4270f into master Oct 24, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant