Repository navigation
fix: stop error notices when toggling Progress Properties and the Kanban helper - #228
Merged
Merged
Conversation
…ban helper Each toggle reconciles both automators with the settings, so the one that was already on got attached again and attach() logged 'a ProgressProperties automator is already attached.' Attaching an attached automator is now a no-op. The notice also read '(ERROR)' because LogManager.logWarning fanned out to each logger's logError. Warnings now go to logWarning and read '(WARNING)'. The docs that described that quirk are updated.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
metaedit-docs | f654f5a | Oct 24 2026, 02:48 PM |
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turn on Progress Properties, then turn on the Kanban Board Helper (or the reverse), and MetaEdit shows an error notice:
Nothing is actually wrong. Every toggle calls
toggleAutomators(), which reconciles both automators with the settings. The automator that was already on gets attached again, andattach()logged that as a warning.OnFileModifyAutomatorManager.attach()now treats an already attached automator as a no-op.(ERROR)becauseLogManager.logWarningcalled each logger'slogError. Warnings now go tologWarning, so they readMetaEdit: (WARNING) ...and useconsole.warn. The only remaining warning is the Kanban helper's "'{property}' not found" notice.reference/notices.md,help/faq.md, andhelp/troubleshooting.md, and quoted(ERROR)in two Kanban pages. They're updated.tests/obsidian-stub.tsgains a smalldebounceso the automator manager can load in unit tests.Verification
masterin Obsidian 1.14.4 (Linux, isolated obsidian-e2e vault) by clicking the two toggles in the settings tab. The notice above appears.["KanbanHelper"], matching the settings.src/automators/onFileModifyAutomatorManager.test.ts: attaching the same type twice shows no notice, andlog.logWarningreports(WARNING). Both fail onmaster's code.pnpm run lint,pnpm run build,pnpm run test(361 passed).Not changed:
LogManager.logErrorstill throws after logging. The Progress Properties catch block calls it, so a failed count update ends in an unhandled rejection after the notice. That's a separate fix.Release impact: user-facing fix, no settings or API changes.
Note
Low Risk
Behavior change is limited to logging and idempotent automator attach; no write paths or settings schema changes.
Overview
Fixes spurious MetaEdit: (ERROR) popups when enabling Progress Properties and the Kanban Board Helper together, and makes real warnings show as (WARNING) instead of (ERROR).
OnFileModifyAutomatorManager.attach() now silently ignores duplicate automator types instead of calling
log.logWarning, becausetoggleAutomators()re-attaches automators that are already on whenever another toggle changes.LogManager.logWarning now fans out to each logger’s
logWarning(notlogError), so notices like missing Kanban properties or missing board files use the correct prefix andconsole.warn.Adds unit tests for duplicate attach and warning formatting, a
debouncestub intests/obsidian-stub.tsfor loading the automator manager in Vitest, and updates docs/FAQ/troubleshooting to drop the old “warnings labeled ERROR” quirk and quote (WARNING) for Kanban messages.Reviewed by Cursor Bugbot for commit f654f5a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix error notices when toggling Progress Properties and the Kanban helper
LogManager.logWarningnow calls each logger's warning handler instead of its error handler, so warnings no longer show the error prefix (logManager.ts)OnFileModifyAutomatorManager.attachreturns silently when the automator type is already attached, instead of logging a warning — settings reconciliation can attempt this (onFileModifyAutomatorManager.ts)debouncestub in the Obsidian test doubleMetaEdit: (ERROR)prefix toMetaEdit: (WARNING)Macroscope summarized 8caa3a1.