Skip to content

[WAF] Enumerate Served by Cloudflare triggers in Security Analytics - #33032

Open
zeinjaber wants to merge 1 commit into
cloudflare:productionfrom
zeinjaber:zein/2026-08-26-security-analytics-served-by-cloudflare-triggers
Open

[WAF] Enumerate Served by Cloudflare triggers in Security Analytics#33032
zeinjaber wants to merge 1 commit into
cloudflare:productionfrom
zeinjaber:zein/2026-08-26-security-analytics-served-by-cloudflare-triggers

Conversation

@zeinjaber

@zeinjaber zeinjaber commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Expand the Served by Cloudflare classification definition in Security Analytics to list all four triggers: cache hits, URL forwarding redirects, /cdn-cgi/ endpoints, and Workers responses. Previously the doc only mentioned 'cached content and redirects'.

Align the Cache Analytics page with a cross-reference to the canonical definition in Security Analytics.

Add a note on the /cdn-cgi/ endpoint page clarifying that /cdn-cgi/ traffic is classified as Served by Cloudflare in Security Analytics.

Tracked by DEE-2812.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 0af87fa.

👉 Fix in your agent 👈
Fix the following review findings in PR #33032 (https://github.com/cloudflare/cloudflare-docs/pull/33032).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-076d5ea26443 · Outdated product names
- **File:** `src/content/docs/waf/analytics/security-analytics.mdx` line 127
- **Issue:** The bullet enumerates "Redirect Rules, Bulk Redirects, and Dynamic Redirects" as separate URL forwarding products, but the linked page (/rules/url-forwarding/) names the current products as Single Redirects, Bulk Redirects, and Snippets. "Redirect Rules" and "Dynamic Redirects" are legacy names for what is now a single product, Single Redirects (which supports both static and dynamic URL redirects), so the list is inaccurate and contradicts the page it links to.
- **Fix:** Use current product names, e.g. "products such as Single Redirects and Bulk Redirects" (optionally adding Snippets, which also generate redirects), or explicitly note the legacy names if the dashboard labels are intended.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
waf/analytics/security-analytics.mdx line 127 Outdated product names — The bullet enumerates "Redirect Rules, Bulk Redirects, and Dynamic Redirects" as separate URL forwarding products, but the linked page (/rules/url-forwarding/) names the current products as Single Redirects, Bulk Redirects, and Snippets. "Redirect Rules" and "Dynamic Redirects" are legacy names for what is now a single product, Single Redirects (which supports both static and dynamic URL redirects), so the list is inaccurate and contradicts the page it links to. Fix: Use current product names, e.g. "products such as Single Redirects and Bulk Redirects" (optionally adding Snippets, which also generate redirects), or explicitly note the legacy names if the dashboard labels are intended.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@zeinjaber

Copy link
Copy Markdown
Collaborator Author

@xmflsct @AdamBouhmad @mbullock1986 @KaydeeDee @danielegm @zaidoon1 @ack-cf - could you please review this PR? thanks.

@zeinjaber
zeinjaber enabled auto-merge (squash) August 27, 2026 20:38
@zeinjaber

Copy link
Copy Markdown
Collaborator Author

/rebase

Expand the Served by Cloudflare classification definition in Security
Analytics to list all four triggers: cache hits, URL forwarding
redirects, /cdn-cgi/ endpoints, and Workers responses. Previously the
doc only mentioned 'cached content and redirects'.

Align the Cache Analytics page with a cross-reference to the canonical
definition in Security Analytics.

Add a note on the /cdn-cgi/ endpoint page clarifying that /cdn-cgi/
traffic is classified as Served by Cloudflare in Security Analytics.

Tracked by SPM-2812.
@zeinjaber
zeinjaber force-pushed the zein/2026-08-26-security-analytics-served-by-cloudflare-triggers branch from 4a6a8e7 to 0af87fa Compare September 8, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants