[WAF] Enumerate Served by Cloudflare triggers in Security Analytics - #33032
Open
zeinjaber wants to merge 1 commit into
Open
Conversation
zeinjaber
requested review from
a team,
AdamBouhmad,
KaydeeDee,
ack-cf,
danielegm,
mbullock1986,
xmflsct and
zaidoon1
as code owners
August 26, 2026 09:45
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #33032 (https://github.com/cloudflare/cloudflare-docs/pull/33032).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-076d5ea26443 · Outdated product names
- **File:** `src/content/docs/waf/analytics/security-analytics.mdx` line 127
- **Issue:** The bullet enumerates "Redirect Rules, Bulk Redirects, and Dynamic Redirects" as separate URL forwarding products, but the linked page (/rules/url-forwarding/) names the current products as Single Redirects, Bulk Redirects, and Snippets. "Redirect Rules" and "Dynamic Redirects" are legacy names for what is now a single product, Single Redirects (which supports both static and dynamic URL redirects), so the list is inaccurate and contradicts the page it links to.
- **Fix:** Use current product names, e.g. "products such as Single Redirects and Bulk Redirects" (optionally adding Snippets, which also generate redirects), or explicitly note the legacy names if the dashboard labels are intended.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Collaborator
Author
|
@xmflsct @AdamBouhmad @mbullock1986 @KaydeeDee @danielegm @zaidoon1 @ack-cf - could you please review this PR? thanks. |
zeinjaber
enabled auto-merge (squash)
August 27, 2026 20:38
Collaborator
Author
|
/rebase |
Expand the Served by Cloudflare classification definition in Security Analytics to list all four triggers: cache hits, URL forwarding redirects, /cdn-cgi/ endpoints, and Workers responses. Previously the doc only mentioned 'cached content and redirects'. Align the Cache Analytics page with a cross-reference to the canonical definition in Security Analytics. Add a note on the /cdn-cgi/ endpoint page clarifying that /cdn-cgi/ traffic is classified as Served by Cloudflare in Security Analytics. Tracked by SPM-2812.
zeinjaber
force-pushed
the
zein/2026-08-26-security-analytics-served-by-cloudflare-triggers
branch
from
September 8, 2026 09:08
4a6a8e7 to
0af87fa
Compare
Sahidya
approved these changes
Sep 9, 2026
xmflsct
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the Served by Cloudflare classification definition in Security Analytics to list all four triggers: cache hits, URL forwarding redirects, /cdn-cgi/ endpoints, and Workers responses. Previously the doc only mentioned 'cached content and redirects'.
Align the Cache Analytics page with a cross-reference to the canonical definition in Security Analytics.
Add a note on the /cdn-cgi/ endpoint page clarifying that /cdn-cgi/ traffic is classified as Served by Cloudflare in Security Analytics.
Tracked by DEE-2812.