Modernise STTouchDisplay - #4
Merged
Merged
Conversation
Owner
Author
Adversarial review of
|
cysp
marked this pull request as ready for review
September 23, 2026 09:33
cysp
force-pushed
the
ci/modernize-ios15
branch
2 times, most recently
from
September 23, 2026 13:51
c01e5b9 to
4e27950
Compare
cysp
force-pushed
the
ci/modernize-ios15
branch
from
September 23, 2026 13:54
4e27950 to
719d32a
Compare
This was referenced Sep 23, 2026
Bring the existing project up to the iOS 15 deployment target, ship both public headers from the static-library product, and ignore newer non-touch UIEvent types so the library builds with current Xcode warnings enabled. Co-authored-by: Ishani Madaan <imadaan@scentregroup.com>
Establish one clang-format style for hand-written Objective-C before changing touch behavior. Leave the generated PNG byte array untouched.
Ignore events from other windows, initialize both view construction paths, and clear markers when the display changes windows.
Run lifecycle and window-scoping tests against the built static library and its exported public header, without introducing a demo app or test host.
Publish the MIT license, identify it in source headers, and document the static-library integration and window-scoped overlay.
cysp
force-pushed
the
ci/modernize-ios15
branch
from
September 23, 2026 14:40
719d32a to
cd7cfed
Compare
cysp
force-pushed
the
ci/modernize-ios15
branch
2 times, most recently
from
September 23, 2026 22:03
07bd001 to
8fa252f
Compare
Use the checked-in library project directly on a macOS 26 runner, pin checkout, and keep workflow dependencies current with Dependabot.
Keep ending markers tracked through their removal animation so a window change clears them along with active markers. Cover an immediate move after touch end while preserving caller-owned subviews.
cysp
force-pushed
the
ci/modernize-ios15
branch
from
September 23, 2026 22:36
8fa252f to
36e7ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the existing Objective-C static library maintainable on iOS 15 and current Xcode without changing its distribution model. This PR contains seven reviewable commits:
Scope
The optional legacy HID geometry remains in this PR. #5 replaces it with public UIKit touch data. #6 adds the separate demo, workspace, and UI tests. Swift Package Manager remains deferred.
STTouchDisplay.halready importedSTTouchDisplayView.h, but the old target copied only the umbrella header into its built product. Exporting the view header makes that public import usable by a consumer without adding the source directory to Header Search Paths.Validation
Supersedes #3. Its iOS 15 deployment target change is included here.