Remove STIOHID support and size markers with UITouch.majorRadius - #5
Merged
Merged
Conversation
This was referenced Sep 23, 2026
Merged
cysp
force-pushed
the
ci/modernize-ios15
branch
from
September 23, 2026 14:40
719d32a to
cd7cfed
Compare
cysp
force-pushed
the
ci/public-touch-radius
branch
3 times, most recently
from
September 23, 2026 15:34
ded3ede to
91a76b5
Compare
cysp
force-pushed
the
ci/modernize-ios15
branch
from
September 23, 2026 16:06
8c4df3b to
07bd001
Compare
cysp
force-pushed
the
ci/public-touch-radius
branch
from
September 23, 2026 16:06
91a76b5 to
2f439e8
Compare
cysp
force-pushed
the
ci/modernize-ios15
branch
from
September 23, 2026 22:03
07bd001 to
8fa252f
Compare
cysp
force-pushed
the
ci/public-touch-radius
branch
2 times, most recently
from
September 23, 2026 22:36
5320bbd to
e83b652
Compare
cysp
force-pushed
the
ci/modernize-ios15
branch
from
September 23, 2026 22:36
8fa252f to
36e7ee6
Compare
cysp
force-pushed
the
ci/public-touch-radius
branch
from
September 23, 2026 23:10
e83b652 to
17a69d7
Compare
cysp
force-pushed
the
ci/public-touch-radius
branch
2 times, most recently
from
September 24, 2026 15:14
aa8482b to
f553ef5
Compare
The optional STIOHID path reads private UIKit selectors and assumes a reconstructed IOHID event layout from 2014. In an iOS 27 simulator probe, the raw type read through that layout disagreed with the IOHID accessor, so the overlay used its fixed-size fallback even with the headers installed. Remove the conditional HID reader and obsolete header search paths. Scale both marker axes uniformly from public UITouch.majorRadius, relative to the existing 5-point reference, and use the default size for nonpositive radii. This drops contact ellipse and rotation rendering. Document the approximation and test scaling and fallback across a moving touch.
cysp
force-pushed
the
ci/public-touch-radius
branch
from
September 26, 2026 09:25
f553ef5 to
01c68ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
STIOHID was an optional compile-time path. With its headers present, STTouchDisplay used private
UIEvent/UITouchselectors and assumed an IOHID event object layout reconstructed in 2014; without them, it used fixed marker geometry. In an iOS 27 simulator probe,IOHIDEventGetType(root)returned digitizer type 11, while the old struct read type 1 from the same event. The reader exited at its type check and used its fixed-size fallback even with the headers present. Behavior on a physical iPhone has not been verified.Behavior change
UITouch.majorRadius, relative to the existing 5-point reference; use the default size for a nonpositive radius.Validation