Skip to content

fix(context-menu): restore pane header targeting - #643

Merged
danshapiro merged 1 commit into
mainfrom
fix/pane-header-context-menu-baseline
Aug 13, 2026
Merged

fix(context-menu): restore pane header targeting#643
danshapiro merged 1 commit into
mainfrom
fix/pane-header-context-menu-baseline

Conversation

@danshapiro

Copy link
Copy Markdown
Owner

Summary

  • restore pane-specific context menus for right-click and primary-button context gestures on pane headers
  • preserve data-context="pane-header", add exact tab/pane identity, and resolve pane headers through the existing pane target
  • add direct parser and rendered-attribute coverage, including safe handling of missing identity fields

Root cause

The pane-header marker stopped context lookup at the header, but the parser did not recognize that marker and the header carried no tab or pane IDs. Parsing therefore returned no pane target and the provider fell back to the global application menu.

Test plan

  • Reproduced on main: pane-context-menu-stability reported 2 failed and 4 passed
  • Focused fixed behavior: 84 passed
  • Related and new unit coverage: 149 passed
  • npm run typecheck: passed
  • npm run lint: passed with 0 errors (11 unrelated existing warnings)
  • npm run test:e2e:a11y-gate:deny: passed
  • Fresh npm run check: passed
    • client: 5,019 passed; 8 skipped
    • server: 4,924 passed; 29 skipped
    • electron: 350 passed
  • Earlier broad-run deadline flakes were rechecked: all three tests passed together and in three repeated focused runs before the fresh full pass

Generated with Amplifier

Preserve the pane-header automation marker while attaching its tab and pane identity, then resolve that marker through the existing pane context-menu target. This prevents header context gestures from falling back to the global menu.

Add direct parser and rendering coverage for valid and incomplete pane identity.

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
@danshapiro
danshapiro merged commit 225a91d into main Aug 13, 2026
3 checks passed
@danshapiro
danshapiro deleted the fix/pane-header-context-menu-baseline branch August 13, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant