fix(context-menu): restore pane header targeting - #643
Merged
Conversation
Preserve the pane-header automation marker while attaching its tab and pane identity, then resolve that marker through the existing pane context-menu target. This prevents header context gestures from falling back to the global menu. Add direct parser and rendering coverage for valid and incomplete pane identity. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-context="pane-header", add exact tab/pane identity, and resolve pane headers through the existing pane targetRoot cause
The pane-header marker stopped context lookup at the header, but the parser did not recognize that marker and the header carried no tab or pane IDs. Parsing therefore returned no pane target and the provider fell back to the global application menu.
Test plan
main:pane-context-menu-stabilityreported 2 failed and 4 passednpm run typecheck: passednpm run lint: passed with 0 errors (11 unrelated existing warnings)npm run test:e2e:a11y-gate:deny: passednpm run check: passedGenerated with Amplifier