Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/context-menu/context-menu-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ export function parseContextTarget(contextId: ContextId, data: ContextDataset):
return data.tabId && data.paneId
? { kind: 'pane', tabId: data.tabId, paneId: data.paneId }
: null
case ContextIds.PaneHeader:
return data.tabId && data.paneId
? { kind: 'pane', tabId: data.tabId, paneId: data.paneId }
: null
case ContextIds.PaneDivider:
return data.tabId && data.splitId
? { kind: 'pane-divider', tabId: data.tabId, splitId: data.splitId }
Expand Down
2 changes: 2 additions & 0 deletions src/components/panes/PaneHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ export default function PaneHeader({
: isActive ? 'bg-muted' : 'bg-muted/50 text-muted-foreground'
)}
data-context={ContextIds.PaneHeader}
data-tab-id={tabId}
data-pane-id={paneId}
onDoubleClick={isRenaming ? undefined : onDoubleClick}
role="banner"
aria-label={`Pane: ${title}`}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,35 @@ describe('parseContextTarget', () => {
expect(result).toEqual({ kind: 'tab', tabId: 'tab-1' })
})

it('parseContextTarget for PaneHeader returns the exact pane target', () => {
const result = parseContextTarget(ContextIds.PaneHeader, {
tabId: 'tab-header',
paneId: 'pane-header',
})

expect(result).toEqual({
kind: 'pane',
tabId: 'tab-header',
paneId: 'pane-header',
})
})

it('parseContextTarget for PaneHeader returns null when tabId is missing', () => {
const result = parseContextTarget(ContextIds.PaneHeader, {
paneId: 'pane-header',
})

expect(result).toBeNull()
})

it('parseContextTarget for PaneHeader returns null when paneId is missing', () => {
const result = parseContextTarget(ContextIds.PaneHeader, {
tabId: 'tab-header',
})

expect(result).toBeNull()
})

it('parseContextTarget for FreshAgent preserves pane and session flavor identity', () => {
const result = parseContextTarget(ContextIds.FreshAgent, {
tabId: 'tab-1',
Expand Down
19 changes: 19 additions & 0 deletions test/unit/client/components/panes/PaneHeader.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,25 @@ describe('PaneHeader', () => {
expect(screen.getByText('My Terminal')).toBeInTheDocument()
})

it('renders its pane-header context marker and exact pane identity', () => {
render(
<PaneHeader
tabId="tab-header"
paneId="pane-header"
title="My Terminal"
status="running"
isActive={true}
onClose={vi.fn()}
content={makeTerminalContent()}
/>
)

const header = screen.getByRole('banner', { name: 'Pane: My Terminal' })
expect(header).toHaveAttribute('data-context', 'pane-header')
expect(header).toHaveAttribute('data-tab-id', 'tab-header')
expect(header).toHaveAttribute('data-pane-id', 'pane-header')
})

it('renders status indicator', () => {
render(
<PaneHeader
Expand Down
Loading