Skip to content

diag: own Location (move from libs/dyn) - #6974

Open
denik wants to merge 7 commits into
denik/diag-paths-structpathfrom
denik/diag-location-structpath
Open

denik wants to merge 7 commits into
denik/diag-paths-structpathfrom
denik/diag-location-structpath

Conversation

@denik

@denik denik commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Location moves from libs/dyn to libs/diag; callers use diag.Location directly. libs/diag no longer imports libs/dyn.

Why

Stacked on #6980 (diagnostic paths use structpath, which removes diag's other dependency on dyn). Prep for #6954, which removes libs/dyn from bundle configuration.

This pull request and its description were written by Isaac.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 52ca95b

Run: 37810054639

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 276 17 5:23
✅​ aws-windows-latest-4core-16gb 278 15 3:57
✅​ azure linux-2core-8gb 275 17 6:05
✅​ azure-windows-latest-4core-16gb 277 15 4:52
✅​ gcp linux-2core-8gb 276 17 5:38
✅​ gcp-windows-latest-4core-16gb 278 15 4:19
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:08 gcp-windows-latest-4core-16gb TestAccept
4:05 azure linux-2core-8gb TestAccept
3:55 aws-windows-latest-4core-16gb TestAccept
3:45 gcp linux-2core-8gb TestAccept
3:43 azure-windows-latest-4core-16gb TestAccept
3:38 aws linux-2core-8gb TestAccept

@denik
denik marked this pull request as ready for review October 7, 2026 12:30
@denik
denik requested review from a team as code owners October 7, 2026 12:30
@github-actions github-actions Bot added the AIR Databricks AI Runtime CLI label Oct 7, 2026
@denik
denik force-pushed the denik/diag-location-structpath branch from c8121ae to 8b3a26a Compare October 7, 2026 13:23
@denik
denik force-pushed the denik/diag-location-structpath branch from 30536d2 to 3afe070 Compare October 7, 2026 14:29
@denik denik changed the title diag: own Location and use structpath for diagnostic paths diag: own Location (move from libs/dyn) Oct 7, 2026
@denik
denik changed the base branch from main to denik/diag-paths-structpath October 7, 2026 14:29
@denik
denik force-pushed the denik/diag-location-structpath branch 5 times, most recently from 53d29f7 to 4be88ef Compare October 8, 2026 07:50
@denik
denik force-pushed the denik/diag-paths-structpath branch from 57f292f to 5f3edeb Compare October 8, 2026 11:11
@denik
denik force-pushed the denik/diag-location-structpath branch 3 times, most recently from c17b428 to 87a5a1d Compare October 8, 2026 11:57
@denik
denik force-pushed the denik/diag-location-structpath branch from 87a5a1d to d4aea66 Compare October 8, 2026 16:20
denik and others added 7 commits October 8, 2026 18:33
Move Location from libs/dyn to libs/diag and use diag.Location directly, so
libs/diag no longer imports libs/dyn.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik force-pushed the denik/diag-paths-structpath branch from 42ccbe5 to 6890bb2 Compare October 8, 2026 16:35
@denik
denik force-pushed the denik/diag-location-structpath branch from d4aea66 to 52ca95b Compare October 8, 2026 16:35

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIR Databricks AI Runtime CLI DABs DABs related issues PyDABs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants