Repository navigation
Conversation
This was referenced Oct 7, 2026
denik
added a commit
that referenced
this pull request
Oct 7, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 6890bb2
Top 6 slowest tests (at least 2 minutes):
|
denik
added a commit
that referenced
this pull request
Oct 8, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/diag-paths-structpath
branch
from
October 8, 2026 11:11
57f292f to
5f3edeb
Compare
Diagnostic.Paths is []*structpath.PathNode; producers convert dyn paths with dyn.ToStructPath(s) or use structpath.MustParsePaths. Map keys that are not identifiers are now quoted in rendered paths. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…import regrouping Co-authored-by: Isaac <no-reply@databricks.com>
Replace NewStringKeys/NewStringKeysSlice and nested NewIndex/NewStringKey chains: NewPath(prev, parts...) takes string keys and int indices. Co-authored-by: Isaac <no-reply@databricks.com>
ToStructPaths copies the walked path, so it no longer needs cloning. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/diag-paths-structpath
branch
from
October 8, 2026 16:35
42ccbe5 to
6890bb2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
diag.Diagnostic.Pathsis[]*structpath.PathNodeinstead of[]dyn.Path. Producers convert existing dyn paths withdyn.ToStructPathsor build paths from keys withstructpath.NewStringKeys/NewStringKeysSlice/MustParsePaths.structpath.PureReferenceToPathmoves todynvar.PureReferenceToStructPathso structpath does not import dyn.User-visible: diagnostic paths quote map keys that are not identifiers, e.g.
resources.jobs['${var.env}_job']instead ofresources.jobs.${var.env}_job(one golden).Why
First step of removing
libs/dynfrom bundle configuration: #6974 movesLocationtolibs/diagon top of this (it needs diag to no longer import dyn), then #6954.This pull request and its description were written by Isaac.