feat(tui): select Flow reviewer from connected models - #78
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe34480bb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choosing a reviewer currently requires editing configuration by hand. Add an optional OpenCode TUI entry point with
/flow-reviewerand a command-palette action that lists connected text/tool-capable models, including an explicit unavailable-current-preference indication.The user confirms before a global preference is saved and OpenCode server instances reload. The picker rechecks current-project activity, provider availability, preference changes, and project/plugin lifetime. It writes only
agent.flow-reviewer.options.flowReviewerModel; it does not round-trip plugins, credentials, or the manager model through the config API. Other projects must be idle before confirmation, as disclosed in the dialog.A nonempty preference overrides tuple/environment reviewer-model settings and uses default reasoning while preserving reviewer steps. A project preference overrides the same global field. “Use default” restores the existing tuple/environment configuration without deleting it. The server applies the preference during configuration and reports its requested source through
/flow-status. No model probe or Flow lifecycle tool is added.Prepares version 8.4.0 and the
./tuiexport. This feature is not published or eligible for the existing narrow patch qualification. No paid evals or canaries ran, and the user's installed configuration was not changed.Validation: native picker and confirmation rendered in an isolated pinned OpenCode 1.18.6 PTY with a synthetic catalog and disabled write transport. The real provider-free host smoke applied/reset the preference through
/global/config, verified effective model/variant/steps after reload, preserved an unrelated environment reference, and created no.flowstate. Unit, architecture, documentation, surface, packaging checks and all 13 gated replays passed.Final push preflight passed: 1,187 tests passed, one opt-in smoke skipped, 45 focused host checks and package smoke passed. The opt-in real host smoke was also run separately and passed 21 tests.