Repository navigation
feat(coroot): give agents read-only MCP access with a Viewer service account #5881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
devantler
wants to merge
4
commits into
main
Choose a base branch
from
claude/coroot-mcp-service-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−4
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
51e3e3c
feat(coroot): give agents read-only MCP access with a Viewer service …
devantler 40030e3
chore: Apply megalinter fixes
botantler-1[bot] 58e8cde
fix(coroot): restart Coroot when the agents' MCP key rotates
devantler 36481ef
test(coroot): expect the MCP key Secret in Coroot's reload annotation
devantler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
.../infrastructure/controllers/coroot/cilium-network-policy-allow-gateway-to-coroot-mcp.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # The Gateway reaches the Coroot app pod directly for exactly one route: the | ||
| # /mcp rule in http-route.yaml, which bypasses oauth2-proxy because Coroot's MCP | ||
| # endpoint authenticates every request with a bearer token itself. Only the | ||
| # Coroot app pod is selected, so no other observability workload becomes | ||
| # reachable from the Gateway. Every other path still arrives through oauth2-proxy | ||
| # and the auth-proxy, which allow-coroot admits. | ||
| --- | ||
| apiVersion: cilium.io/v2 | ||
| kind: CiliumNetworkPolicy | ||
| metadata: | ||
| name: allow-gateway-to-coroot-mcp | ||
| namespace: observability | ||
| spec: | ||
| endpointSelector: | ||
| matchLabels: | ||
| app.kubernetes.io/part-of: coroot | ||
| app.kubernetes.io/component: coroot | ||
| ingress: | ||
| - fromEntities: | ||
| - ingress | ||
| toPorts: | ||
| - ports: | ||
| - port: "8080" | ||
| protocol: TCP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.