CI: speed up formatting and check symbol regressions against the base - #162
Merged
Merged
Conversation
fjooord
marked this pull request as draft
September 15, 2026 20:08
Mrkol
requested changes
Sep 15, 2026
Contributor
Author
|
Included the whitespace-only fix in The exact workflow command now passes locally across all 1,475 tracked source files in one Docker container, taking 15.7 seconds with the image cached. Including this fix should let the full-tree formatting job pass when this PR is merged. Remote CI still needs to confirm; this formatting result does not establish build success. |
fjooord
marked this pull request as ready for review
September 15, 2026 20:28
Report for GMSJ01 (aeebbbf - 8bfaa54)📉 Matched code: 39.16% (-0.09%, -3304 bytes) 🥀 5 broken matches
📉 2 regressions in unmatched items
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Check All Formatting in One Container
Run clang-format 21 across all tracked source files in one Docker container. No automatic edits or custom formatting helper.
include/JSystem/JAudio/JALibrary/JALList.hpp, the only file failing formatting. The full-tree check now passes locally.2. Fail on New Symbol Defects
#161 compiled and generated its report, then failed symbol-map validation. Compare against a separately built upstream base: inherited defects become warnings; new missing symbols, ordering errors, or incorrect linkage fail CI.
Previously empty objects get no exemptions. If the base object has no function symbols, its first implementation must pass strict validation.
Compiler errors and missing validation inputs still fail. Standalone validation stays strict. This does not implement missing functions or repair existing symbol defects.
Validation: 15 local checks pass, including empty-baseline behavior. No test files or test steps are added to the PR. Game implementation changes stay in #161.