Rework unary ops - #632
Open
arcondello wants to merge 1 commit into
Open
Rework unary ops#632arcondello wants to merge 1 commit into
arcondello wants to merge 1 commit into
Conversation
fastbodin
reviewed
Sep 18, 2026
Comment on lines
+42
to
+45
| assert( | ||
| domain <= UnaryOp::template domain<T> and | ||
| "input domain must be a subset of the func's domain" | ||
| ); |
Collaborator
There was a problem hiding this comment.
Took me a HOT minute to realize the two domain here were different 🤦
| struct logical : UnaryOpMixin<logical> { | ||
| static bool operator()(const DType auto& x) { return x; } | ||
|
|
||
| static interval<bool> operator()(const interval<bool>& domain) { return domain; } |
Collaborator
There was a problem hiding this comment.
Confirming that, the reason we do not need
if (not static_cast<bool>(domain)) return {}; // op(empty domain) -> empty domainhere is because it is absorbed by returning domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the ops in
functional.hppto carry more information. This is then used in some bigger changes to:UnaryOpNodeReworkUnaryOpNode#627AI Generation Disclosure
Claude helped a lot with this one. Mostly by catching edge cases in the funcs, implementing a few of them once I showed it the pattern (e.g.,
rint) and by helping to write the tests. In the end, most of the code was actually written by me once I made all the changes I wanted.