Repository navigation
Improve Oracle OSON binary JSON encoding and decoding - #1749
Merged
Merged
Conversation
Resolves eclipse-vertx#1703 Read path: handle all OSON extended types (timestamps, intervals, binary) as JSON-safe types that survive `JsonObject.encode()`. Extended types are converted to strings (timestamps, intervals) or `Buffer` (binary) since these are the closest JSON-compatible representations that preserve enough information for users to convert back to the original types. Write path: replace the three-step serialization (`JsonObject` → JSON text → parse → OSON binary) with a direct `OracleJsonGenerator` walk over the internal map/list, avoiding unnecessary intermediate representations. Strings stay as strings on the write path because ambiguity makes guessing unsafe (e.g. "P2Y3M" could be a product code). Assisted-by: Claude Opus 4.6 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1703
Read path: handle all OSON extended types (timestamps, intervals, binary) as JSON-safe types that survive
JsonObject.encode(). Extended types are converted to strings (timestamps, intervals) orBuffer(binary) since these are the closest JSON-compatible representations that preserve enough information for users to convert back to the original types.Write path: replace the three-step serialization (
JsonObject→ JSON text → parse → OSON binary) with a directOracleJsonGeneratorwalk over the internal map/list, avoiding unnecessary intermediate representations. Strings stay as strings on the write path because ambiguity makes guessing unsafe (e.g. "P2Y3M" could be a product code).Assisted-by: Claude Opus 4.6