Repository navigation
Conversation
…pty, not for 100ms ExecutionPollingMetadata::createWithTestingSetup() limits a run to 100ms of wall-clock time, and the consumer stops after any poll that ends past it. Five catalogue stages need more than one poll in a single run: the round-robin dynamic channel (orders_a, then orders_b), two commands on one queue, a handler feeding its own channel, a retry before the dead letter, and an error channel send that fails on the redelivery. On a slow runner the first message alone took over 100ms, the run stopped, and the second message was never received. These stages now run with createWithFinishWhenNoMessages(), which stops only once the queue is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change proposed?
Why
Flow conformance stages that consume more than one message now keep polling until their queue is empty, so a slow CI runner no longer fails them.
These stages polled with
ExecutionPollingMetadata::createWithTestingSetup(), which stops the consumer after any poll that ends past 100ms. When the first message took longer than that, the consumer stopped before the second message and the expected span tree was missing. This failed Split Testing (8.5) on #727 (job): "dynamic channel sends round robin to its channels" recorded the send toorders_bbut no receive under it. The push run on the same commit passed.Before / after
Description of Changes
createWithFinishWhenNoMessages(): round robin across two channels, two commands on one queue, a handler feeding its own channel, retry then dead letter, and a failing error-channel send.Pull Request Contribution Terms