Skip to content

test: keep polling multi-message flow conformance stages until the queue is empty #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgafka wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

test: keep polling multi-message flow conformance stages until the queue is empty #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/Ecotone/src/Test/Flow/AsynchronousFlowScenarios.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function notify(string $userId): void
)
->expectNoSpanNamed('process class@anonymous::register')
->withNoOtherSpans(),
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('async_channel', ExecutionPollingMetadata::createWithTestingSetup(handledMessageLimit: 2)))
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('async_channel', ExecutionPollingMetadata::createWithFinishWhenNoMessages()))
->expect(
ExpectedSpan::named('receive async_channel')->ofKind(SpanKind::Consumer)->containing(
ExpectedSpan::named('process class@anonymous::register')->withAttributes([SpanAttribute::ENDPOINT_ID => 'user.registration'])->containing(
Expand Down
2 changes: 1 addition & 1 deletion packages/Ecotone/src/Test/Flow/ChannelFailureFlowScenarios.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ public function register(string $userId): void
ServiceConfiguration::createWithDefaults()->withDefaultErrorChannel('error_channel'),
], [
self::registrationSentToTheQueue(),
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('users', ExecutionPollingMetadata::createWithTestingSetup(stopOnError: false)))
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('users', ExecutionPollingMetadata::createWithFinishWhenNoMessages(stopOnError: false)))
->failingWith('Exception on send')
->expect(
ExpectedSpan::named('receive users')->ofKind(SpanKind::Consumer)->withStatus(SpanStatus::Error)->containing(
Expand Down
2 changes: 1 addition & 1 deletion packages/Ecotone/src/Test/Flow/ChannelFlowScenarios.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public function place(string $orderId): void
)
->withNoOtherSpans()
->leavingWorkPending(),
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('orders', ExecutionPollingMetadata::createWithTestingSetup(handledMessageLimit: 2)))
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('orders', ExecutionPollingMetadata::createWithFinishWhenNoMessages()))
->expect(
ExpectedSpan::named('send orders_a')->containing(ExpectedSpan::named('receive orders')->withAttributes(['flowId' => '1'])->containing(ExpectedSpan::named('process class@anonymous::place'))),
ExpectedSpan::named('send orders_b')->containing(ExpectedSpan::named('receive orders')->withAttributes(['flowId' => '2'])->containing(ExpectedSpan::named('process class@anonymous::place'))),
Expand Down
2 changes: 1 addition & 1 deletion packages/Ecotone/src/Test/Flow/RecoverabilityFlowScenarios.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ private static function failureRetriedWithDelayThenSentToDeadLetter(): FlowScena
->expect(self::queued())
->withNoOtherSpans()
->leavingWorkPending(),
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('orders', ExecutionPollingMetadata::createWithTestingSetup(stopOnError: false)))
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('orders', ExecutionPollingMetadata::createWithFinishWhenNoMessages(stopOnError: false)))
->expect(
ExpectedSpan::named('receive orders')->withStatus(SpanStatus::Error)->containing(
ExpectedSpan::named('process class@anonymous::place')->withStatus(SpanStatus::Error, 'Order cannot be placed'),
Expand Down
2 changes: 1 addition & 1 deletion packages/Ecotone/src/Test/Flow/TraceFlowScenarios.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private static function twoAsynchronousCommandsKeepTheirOwnTraces(): FlowScenari
return new FlowScenario('two asynchronous commands consumed in one run keep their own traces', [$users::class], [$users], [SimpleMessageChannelBuilder::createQueueChannel('users')], [
$send('1'),
$send('2'),
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('users', ExecutionPollingMetadata::createWithTestingSetup(handledMessageLimit: 2)))
FlowStage::when(fn (FlowTestSupport $ecotone) => $ecotone->run('users', ExecutionPollingMetadata::createWithFinishWhenNoMessages()))
->expect($consumed('1'), $consumed('2')),
]);
}
Expand Down
Loading