Repository navigation
Raise httpc's header limit for precompiled downloads - #98
Merged
Merged
Conversation
GitHub's release-download redirects now send about 11 KB of response headers, most of it a content-security-policy. That exceeds the 10 KiB max_header_size httpc enforces by default in recent Erlang/OTP patch releases, so precompiled NIF downloads fail with header_too_long. Raise the limit to 64 KiB for these requests.
cocoa-xu
approved these changes
Oct 24, 2026
miguelcoba
approved these changes
Oct 24, 2026
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's release-download redirects now send about 11 KB of response headers. Erlang/OTP 29.0.6, 28.5.0.6 and 27.3.4.17 added an httpc
max_header_sizerequest option that defaults to 10,240 bytes, so precompiled NIF downloads fail there:This raises the limit to 64 KiB, as philss/rustler_precompiled#113 does. Older releases log a notice and ignore the option. The new test can only fail on a release that enforces the limit, so on OTP 25 it passes either way.