Repository navigation
ci(eosim): install EoSim through the shared install-eosim action in the Linux sim jobs - #49
Conversation
|
Review (daily loop) — clean, well-scoped adoption. Replacing the hand-written clone-and-install with the shared action in the two Linux jobs is exactly the org-wide pattern the research track recommends, and keeping the single Two small notes:
No merge from me per the standing rule — but this one has my full support for a maintainer merge. |
Extends Kartikey's #49 (which converts the two Linux jobs in eosim-sanity.yml) to the other ubuntu-latest jobs still hand-rolling the clone: mobile-test.yml, nightly.yml, simulation-test.yml (eos-platforms + eapps-on-eosim), release-native.yml and stable-release.yml. Same template: pinned tag resolved + validated by the action (fail-closed on bad tags), single EOSIM_VERSION pin where the workflow has one (release-native/stable-release keep their explicit 3.0.2 pin). Untouched: the cross-platform matrix job (runs on Windows/macOS too — the action's resolve step needs python3, tracked as follow-up in #49) and the Windows/macOS EoSim jobs.
|
@Aswin-V a correction before anything goes into the README: the Windows limitation I gave as the reason for the carve-out isn't real. I hadn't tested it, and now I have. Probe: a run of the action itself from
So there's nothing to document as a limitation, and the carve-out has no reason to exist. I'll extend this PR, eAI#52 and eBoot#149 to the Windows, macOS and cross-OS matrix jobs too, and run each workflow on my fork before asking for review. On your second note, I'll open a separate README fix: the Usage section shows |
…he Linux sim jobs — Closes embeddedos-org#48 eos-simulation and nested-guest-install now use embeddedos-org/.github/.github/actions/install-eosim@master with version: ${{ env.EOSIM_VERSION }}, so the tag is validated against the remote and fails closed instead of 404ing. The cross-OS install matrix and the Windows/macOS jobs keep the direct clone for now: the action's resolve step calls python3, which setup-python does not guarantee on Windows. Refs embeddedos-org/ebuild#128.
… Linux — refs embeddedos-org#48 The Windows, macOS and cross-OS matrix jobs were left on the direct clone on the assumption that setup-python does not provide python3 on Windows. That assumption was wrong: on windows-latest setup-python puts python3 on PATH, and the action resolves, installs and verifies v3.0.2 on ubuntu-latest, macos-latest and windows-latest (probe run Kartikey1306/.github actions run 37668634240). Per the org standard (.github docs/install-eosim-standard.md), every remaining inline clone-and-install in .github/workflows now uses the action; workflows that pin a literal v3.0.2 pass version "3.0.2".
5e0f575 to
d17808c
Compare
Closes #48
Refs embeddedos-org/ebuild#128. Builds on d7b323a (your extension on master); this PR now covers only what that left out.
Every EoSim install in
.github/workflowsnow goes through the org's shared action. After this PR there's no inlinegit clone … EoSimleft in the repo:eosim-sanity.yml: every job (Install matrix on ubuntu, windows and macos × Py 3.10–3.12, EoS Sim, Guest OS, Windows EoSim, macOS EoSim).simulation-test.yml: the cross-platformHost Validatejob.weekly.yml: its EoSim step.Correction to this PR's first version: it left the Windows, macOS and cross-OS matrix jobs on the direct clone, claiming
setup-pythondoesn't providepython3on Windows. That was wrong. A probe of the action onubuntu-latest,macos-latestandwindows-latestpasses everywhere: https://github.com/Kartikey1306/.github/actions/runs/37668634240. On Windows,python3resolves to/c/hostedtoolcache/windows/Python/3.12.10/x64/python3.Verification: the changed workflows, dispatched from this branch on my fork. Every job is green, including the Windows and macOS legs on Python 3.10, 3.11 and 3.12:
Plus actionlint 1.7.12 on every changed workflow.