Repository navigation
ci(eosim): install EoSim through the org's pinned install-eosim action - #149
Merged
srpatcha merged 2 commits intoOct 8, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…n — Closes embeddedos-org#148, refs embeddedos-org/ebuild#128 The Linux jobs nested-simulation and nested-guest-install replace their hand-written clone and pip install with embeddedos-org/.github/.github/actions/install-eosim@master, still pinned by the one EOSIM_VERSION (3.0.2). The action validates the tag, fails closed on an unknown one and checks the installed version. The cross-OS install matrix and the Windows and macOS jobs keep the direct clone: the action's resolve step runs python3, which setup-python does not guarantee on Windows (same split as eApps#49).
… Linux — refs embeddedos-org#148 The Windows, macOS and cross-OS matrix jobs were left on the direct clone on the assumption that setup-python does not provide python3 on Windows. That assumption was wrong: on windows-latest setup-python puts python3 on PATH, and the action resolves, installs and verifies v3.0.2 on ubuntu-latest, macos-latest and windows-latest (probe run Kartikey1306/.github actions run 37668634240). Per the org standard (.github docs/install-eosim-standard.md), every remaining inline clone-and-install in .github/workflows now uses the action; workflows that pin a literal v3.0.2 pass version "3.0.2".
Kartikey1306
force-pushed
the
ci/adopt-install-eosim
branch
from
October 7, 2026 18:49
0d6d58e to
f0fa0f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
Refs embeddedos-org/ebuild#128
Every EoSim install in
.github/workflowsnow goes through the org's shared action. After this PR there's no inlinegit clone … EoSimleft in the repo:eosim-sanity.yml: every job (Install & Validate on ubuntu, windows and macos × Py 3.10–3.12, Nested Simulation, Guest OS Install, Windows Sanity, macOS Sanity). The Windows and macOS jobs keep their platform-count assertion, now after the action's install.simulation-test.yml: both of its install steps.Correction to this PR's first version: it left the Windows, macOS and cross-OS matrix jobs on the direct clone, claiming
setup-pythondoesn't providepython3on Windows. That was wrong. A probe of the action onubuntu-latest,macos-latestandwindows-latestpasses everywhere: https://github.com/Kartikey1306/.github/actions/runs/37668634240. On Windows,python3resolves to/c/hostedtoolcache/windows/Python/3.12.10/x64/python3.Verification: the changed workflows, dispatched from this branch on my fork. Every job is green, including the Windows and macOS legs on Python 3.10, 3.11 and 3.12:
Plus actionlint 1.7.12 on every changed workflow.