Repository navigation
Give the caption golden's polygon and polyline a stroke colour - #107
Merged
Merged
Conversation
EPDFMeasureEmbedderTest.CaptionAppearanceGolden failed the release's Linux source tests on main (8074892, run 41716790696): 1,322 pixels differ. The CI's actual and expected images differ only in the bottom row, where the polygon and polyline lost their black outlines. The test never gives those two a /C, and since #104 (no stroke) a shape without one draws no outline, as Acrobat does. #104 already set a colour in the measurement tests' line helper; this test builds its shapes itself. Now they are black, so the golden draws as before and measure_captions.png is unchanged. On Linux in Docker the release job's suites now pass in full: unit 1,327, embedder 1,777. On macOS this test already failed before #104: measure_captions_mac.png is stale for another reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release on
embedpdf/main(8074892, run 41716790696) failed its Linux source tests on one test,EPDFMeasureEmbedderTest.CaptionAppearanceGolden, with 1,322 pixels different.The actual and expected images in the CI log differ only in the bottom row: the polygon and polyline lost their black outlines. The test never gives those two shapes a
/C, and since #104 (no stroke) a shape without one draws no outline, as Acrobat does. #104 set a colour in the measurement tests' line helper, but this test builds its shapes itself. The dimension lines are pixel-identical, so #105 and #106 aren't involved.This change gives the polygon and polyline a black stroke, so they draw as before and
measure_captions.pngstays as it is. It changes the test only.On Linux in Docker, the release job's suites now pass in full: unit 1,327, embedder 1,777. On macOS this test already failed before #104;
measure_captions_mac.pngis out of date for another reason.