Repository navigation
Conversation
niemyjski
force-pushed
the
issue/microsoft-email-ownership
branch
from
October 22, 2026 19:32
d58fd2f to
2e63c4e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2630. This draft contains only the proposed Microsoft email-ownership policy and its regression tests. The provider migration is already merged in #2403; review this behavior change separately from external-account state handling.
Why
The OAuth2 Microsoft client maps Graph
mail, falling back touserPrincipalName, without a mailbox-verification assertion. Microsoft documents that a privileged tenant user can assign an unverifiedMailvalue to an account without a mailbox. Matching that reported address alone can attach an unrecognized Microsoft identity to an existing Exceptionless account.Proposed behavior
The generic OpenAPI 403 description remains unchanged. The
Createdresult is internal: it identifies initial account creation so verification mail is attempted once, after invitation processing; the endpoint still returns the normal authentication-token response.Dependencies
EmailVerifiedand GoogleProviderData["hd"]metadata. Its Microsoft client still supplies no verification assertion. A broader Google/GitHub policy using that metadata would require a released package containing Update StripeEventHandler.cs #163 (or an equivalent adapter); that work is outside this draft.Limitations for review
Validation
2e63c4e2: all four backend shards (including service-backed HTTP regressions), frontend checks/tests, all six browser shards, and image builds. Live Microsoft consent/Graph calls are not part of these automated tests.