[codex] Add multi-author commit attribution - #28
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b764e7e2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let authors = if wire.authors.is_empty() { | ||
| vec![wire.author] | ||
| } else { | ||
| wire.authors |
There was a problem hiding this comment.
Preserve primary
author during commit deserialization
When both author and authors are present, this logic discards author whenever authors is non-empty and then derives the primary author from authors[0]. That is a regression for mixed-format commit JSON (e.g., producers that treat authors as co-authors-only), because a commit that previously resolved to the explicit author will now silently change attribution to a different person. Deserialization should keep author authoritative (or validate/normalize consistency) instead of overwriting it from authors.
Useful? React with 👍 / 👎.
Summary
authors: Vec<Author>commit field while keeping the existing primaryauthorfield for compatibility.authorslist.VEDIT_CO_AUTHORSentries formatted asName <email>separated by semicolons.vedit logandvedit show.Validation
cargo testVEDIT_AUTHOR_NAME,VEDIT_AUTHOR_EMAIL, and twoVEDIT_CO_AUTHORSentries, verifyinglogandshowoutput.Notes
This implements the valid core/CLI portion of #20 in the current repository layout. The issue also mentions
vedit_blameand oldcrates/core/src/vcpaths, but this repo currently has no blame command or those paths, so that part remains out of scope until such a surface exists.Closes #20.