Repository navigation
fix(ci): harden simulator setup script and runtime matching - #1886
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves simulator setup and testing scripts by explicitly invoking them with bash, refining runtime detection to match major and minor versions, and cleaning up existing unavailable simulators before creation. Feedback on these changes suggests optimizing version extraction using Bash's built-in regex matching instead of subshells, correcting backslash escaping in parameter expansion for runtime filtering, and making the UUID regex case-insensitive to robustly handle lowercase characters.
ncooke3
enabled auto-merge (squash)
October 29, 2026 16:49
Member
Author
|
Firestore failure is expected |
daymxn
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1882 to harden simulator provisioning when multiple point-release runtimes or unavailable duplicate devices exist on shared macOS runners.
This PR updates
scripts/setup_simulator.sh,.github/actions/setup_simulator/action.yml, andscripts/test.shto:major.minorSDK runtime matching (e.g.,iOS 26.4for Xcode 26.4 onmacos-26where26.2,26.4, and26.5runtimes are installed side-by-side) before falling back to major-version matching.grep -Fqdevice matching, tolerate leading whitespace insimctl list runtimes, explicitly invokesetup_simulator.shviabash, and only auto-runsetup_simulator.shfromscripts/test.shwhenDEVICEuses aFirebase-prefix.