[material_ui] Default gen_defaults color helper prefix - #12848
Open
QuncCccccc wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors several template files under packages/material_ui/tool/gen_defaults/templates/ and their associated tests by making the prefix parameter of the color and colorWithOpacity helper methods optional with a default value of '_colors'. This allows removing the explicit '_colors' argument from numerous calls across the templates. The reviewer suggests replacing deprecated MaterialStatePropertyAll with WidgetStatePropertyAll in button_template.dart, utilizing the inherited border helper method instead of explicitly instantiating BorderSide, and simplifying redundant conditional branches in the iconColor resolver.
QuncCccccc
force-pushed
the
gen_defaults_color_prefix_defaults
branch
from
September 12, 2026 03:51
928a58e to
4d83ce0
Compare
This was referenced Sep 12, 2026
navaronbracke
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward flutter/flutter#187899.
Follow-up to #12846.
While migrating the M3 templates, I noticed that existing templates use
_colorsas the prefix passed tocolorandcolorWithOpacity. This PR makes_colorsthe default value for theprefixargument and removes the now-redundant explicit arguments from existing templates. Explicit custom prefixes remain supported, and regenerating the enabled templates produces no changes to the checked-in generated defaults.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2