This repository was archived by the owner on Oct 23, 2026. It is now read-only.
Repository navigation
fix(error-reporting): silence undici TypeError: terminated network errors (CLI-2AD) - #1653
Closed
sentry[bot] wants to merge 2 commits into
Closed
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
Closing as part of archiving getsentry/cli; the CLI now lives in getsentry/toolkit. Ported as getsentry/toolkit#1606, minus the regenerated date examples in the skill references. |
BYK
added a commit
to getsentry/toolkit
that referenced
this pull request
Oct 23, 2026
…1606) Two kinds of user-environment failures still show up in Sentry as CLI issues: - **`TypeError: terminated`** ([CLI-2AD](https://sentry.sentry.io/issues/7624167935/)): undici throws this when the connection drops while the response body is streaming. #1548 already retries finite GET bodies, so one that still gets through is the same offline/proxy noise as `fetch failed`. `isNetworkError()` now matches it too. - **Bad sourcemap directory** ([CLI-1FN](https://sentry.sentry.io/issues/7439660891/)): `assertDirectoryReadable` throws a `ValidationError` with field `"directory"` when the directory doesn't exist, isn't a directory, or can't be read. This is now silenced the same way as the missing `--input` file case (CLI-1JY). The original getsentry/cli#1616 silenced **every** `ValidationError` and changed `paginate()` back to fixed page sizes. That conflicts with the targeted silencing policy here and with getsentry/cli#1615, so this port only covers the sourcemap directory case. Ported from getsentry/cli#1653 and getsentry/cli#1616, which are being closed with the repo archive. <!-- junior-request-attribution:start --> via **BYK**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:local%3Aweb%3Ad9c5b0de1ecf3c7114be7025 --> -- [View Junior Session in Sentry](https://sentry.sentry.io/explore/conversations/local%3Aweb%3Ad9c5b0de1ecf3c7114be7025/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: BYK <burak.kaya@sentry.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a network connection dropped after response headers but before the full body was received, Node.js's
fetch(undici) would throw aTypeError: terminated. These errors were not being silenced by the CLI's error reporting mechanism becauseisNetworkError()only checked forTypeError: "fetch failed".This meant that environmental network issues were being reported to Sentry as if they were CLI bugs.
This change extends
isNetworkError()to also recognizeTypeError: "terminated"as a network error. This ensures that such errors are correctly classified asnetwork_errorand silenced, consistent with the intent to not report user-environment-related network failures. JSDoc comments have been updated to reflect this behavior, and new tests have been added to cover theterminatederror type.Fixes CLI-2AD
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.