Repository navigation
fix(cli): Silence dropped connections and bad sourcemap directories - #1606
Merged
Merged
Conversation
Two kinds of user-environment failures still reached Sentry as issues: - undici aborts a response body with `TypeError: terminated` when the connection drops mid-stream (CLI-2AD). GET bodies are already retried, so one that still escapes is the same offline/proxy noise as `fetch failed` and is now treated as a network error. - A missing, non-directory, or unreadable sourcemap directory throws a ValidationError with field "directory" (CLI-1FN). It is now silenced like the missing --input file case. Other ValidationErrors stay captured. Ported from getsentry/cli#1653 and getsentry/cli#1616. Co-Authored-By: BYK <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Oct 22, 2026
BYK
approved these changes
Oct 23, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two kinds of user-environment failures still show up in Sentry as CLI issues:
TypeError: terminated(CLI-2AD): undici throws this when the connection drops while the response body is streaming. fix(cli): retry interrupted GET responses across commands #1548 already retries finite GET bodies, so one that still gets through is the same offline/proxy noise asfetch failed.isNetworkError()now matches it too.assertDirectoryReadablethrows aValidationErrorwith field"directory"when the directory doesn't exist, isn't a directory, or can't be read. This is now silenced the same way as the missing--inputfile case (CLI-1JY).The original getsentry/cli#1616 silenced every
ValidationErrorand changedpaginate()back to fixed page sizes. That conflicts with the targeted silencing policy here and with getsentry/cli#1615, so this port only covers the sourcemap directory case.Ported from getsentry/cli#1653 and getsentry/cli#1616, which are being closed with the repo archive.
via BYK.
--
View Junior Session in Sentry