Repository navigation
chore(deps): Bump Playwright to 1.64.1 and pin it exactly - #25382
Merged
Merged
Conversation
mydea
added this pull request to stack #25385
October 15, 2026 07:44
mydea
force-pushed
the
chore/bump-playwright-1.64
branch
from
October 15, 2026 11:35
b56442c to
21b34b1
Compare
mydea
removed this pull request from stack #25385
October 15, 2026 11:37
mydea
added this pull request to stack #25392
October 15, 2026 11:37
mydea
force-pushed
the
chore/bump-playwright-1.64
branch
from
October 15, 2026 11:58
21b34b1 to
bc77523
Compare
mydea
removed this pull request from stack #25392
October 15, 2026 11:58
mydea
added this pull request to stack #25397
October 15, 2026 11:58
mydea
marked this pull request as ready for review
October 15, 2026 12:37
mydea
requested review from
logaretm and
msonnb
and removed request for
a team
October 15, 2026 12:37
mydea
removed this pull request from stack #25397
October 15, 2026 12:51
mydea
added this pull request to stack #25401
October 15, 2026 12:52
mydea
removed this pull request from stack #25401
October 15, 2026 12:55
mydea
added this pull request to stack #25405
October 15, 2026 12:55
msonnb
approved these changes
Oct 15, 2026
mydea
force-pushed
the
chore/bump-playwright-1.64
branch
from
October 15, 2026 14:28
bc77523 to
429390f
Compare
mydea
force-pushed
the
chore/bump-playwright-1.64
branch
from
October 16, 2026 07:35
429390f to
4aebfe5
Compare
mydea
added a commit
that referenced
this pull request
Oct 16, 2026
…25398) The `Waits for sse streaming when sse has been explicitly aborted` test checked for the abort error in the console immediately after the spans arrived. The `sse fetch call` span ends when `fetch` resolves, but the `console.error` only happens after the aborted `reader.read()` rejects, and Playwright delivers console events asynchronously. Nothing orders the two, so the console message sometimes hadn't been recorded yet. The assertion now polls for it. The assertion also matched on `BodyStreamBuffer was aborted`, which only older Chromium logs. Since Playwright 1.64 (#25382), Chromium rejects the read with the signal's abort reason (`AbortError: signal is aborted without reason`), so the test failed on every run there. It now matches any `AbortError`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
chore/bump-playwright-1.64
branch
2 times, most recently
from
October 19, 2026 08:01
3462c29 to
e676717
Compare
`install-playwright` installs the browsers for the version declared in package.json. With a range, an app could resolve a newer patch release than the browsers that were installed, so the version is now pinned exactly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
chore/bump-playwright-1.64
branch
from
October 19, 2026 09:02
e676717 to
1b2bd9e
Compare
mydea
added a commit
that referenced
this pull request
Oct 19, 2026
Test apps depended on `@sentry-internal/test-utils` via `link:../../../test-utils`. Its imports (`express`, `ws`) therefore resolved from the monorepo's root `node_modules`, so E2E jobs needed that restored even though the apps install everything else themselves. test-utils is now packed like the SDK packages, and its tarball gets its own artifact so it can't end up among the release tarballs. Apps depend on it directly with `file:../../packed/sentry-internal-test-utils-packed.tgz`, so pnpm installs its dependencies into each app. It is also pinned through the pnpm overrides like the SDK packages, which is redundant but harmless. Locally, changes to test-utils now need `yarn build:tarball`, as for the SDK packages. Stacked on #25382. Replaces #25396, which GitHub closed as merged by accident during a restack. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@playwright/testfrom~1.63.0to 1.64.1 in the root workspace packages, the@sentry-internal/test-utilspeer range and every E2E app.The version is now pinned exactly, without
~.install-playwright(#25380) installs browsers for the version declared inpackage.json. With a range, an app could resolve a newer patch release than the browsers that were installed, and Playwright patch releases sometimes ship a new browser build.Of the 1.64 breaking changes, the most likely to matter here is that device descriptors now forward
screen. Replay snapshot tests use those descriptors and still pass locally.Stacked on #25381.
🤖 Generated with Claude Code