Repository navigation
ci(e2e): Run E2E tests without restoring the monorepo's node_modules - #25403
Merged
mydea merged 2 commits intoOct 19, 2026
Merged
Conversation
mydea
added this pull request to stack #25405
October 15, 2026 12:55
mydea
force-pushed
the
ci/e2e-without-root-node-modules
branch
from
October 15, 2026 14:28
64925fb to
f0bf393
Compare
mydea
force-pushed
the
ci/e2e-without-root-node-modules
branch
2 times, most recently
from
October 16, 2026 08:52
0113a54 to
c3e497e
Compare
mydea
marked this pull request as ready for review
October 16, 2026 11:18
msonnb
approved these changes
Oct 16, 2026
andreiborza
approved these changes
Oct 16, 2026
mydea
force-pushed
the
ci/e2e-without-root-node-modules
branch
from
October 19, 2026 08:17
5225fe3 to
b2e5641
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b2e5641. Configure here.
Contributor
size-limit report 📦
|
E2E jobs restored the ~860 MB root dependency cache and the full build output only to run a few tsx scripts and to resolve the linked test-utils package. The scripts are now plain .mjs files without dependencies, and test-utils is installed from a tarball like the SDK packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With all scripts as plain .mjs files, the local runner no longer needs tsx, dotenv or glob. esbuild was unused. Type checking of this package was never run in CI, so it no longer has a tsconfig; the JSDoc types are kept for editors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
ci/e2e-without-root-node-modules
branch
from
October 19, 2026 09:06
b2e5641 to
525339c
Compare
mydea
added a commit
that referenced
this pull request
Oct 19, 2026
Removes the `envelopeDumpPath` option of the event proxy, its use in the Next.js and `cloudflare-think` apps, the CI steps that uploaded the dumps on failure, and `scripts/normalize-e2e-test-dump-transaction-events.js`. Dumps were added in #13998 to compare transaction span trees across Next.js versions. Nobody uses them: the normalization step has matched no files since E2E apps started running in a temp directory (#16783), and nobody noticed. It also only reads `transaction` envelopes, so it can't handle span streaming, which is now the default. Stacked on #25403. Replaces #25393, which GitHub closed as merged by accident during a restack. Its review history is still there. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
mydea
added a commit
that referenced
this pull request
Oct 19, 2026
) Since #25403, E2E jobs no longer restore the root `node_modules`. pnpm then installs all 63 workspace projects before the first `pnpm run test:prepare`, because `verify-deps-before-run` finds the dependencies missing. That's about 26s per E2E job, which cancels out most of what #25403 saved. It also made the background Playwright install flaky: its `npx` ran from the repo root and could find the hoisted `node_modules/playwright` before pnpm had linked its binary (`playwright: not found`). The scripts run with `pnpm run` here are plain `node` scripts, so disabling the check is enough. It's set per job, so local runs keep it. Without the long install, the foreground steps start in quick succession, which exposes a runner bug. The runner sets up the steps of a background composite action from the job's shared `github` context ([`CompositeActionHandler.cs`](https://github.com/actions/runner/blob/main/src/Runner.Worker/Handlers/CompositeActionHandler.cs) → `GitHubContext.ShallowCopy()`). If a foreground step starts at that moment, this fails with `Collection was modified; enumeration operation may not execute`. The background install now starts right before the app build, so nothing else starts while it sets up. The steps it no longer overlaps with take well under a second. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each E2E job restored the full ~860 MB root dependency cache and the build output (about 33s per job, ~2.5 runner-hours per CI run) only to run a few
tsxscripts and to resolve@sentry-internal/test-utils. Since #25402 installs test-utils from a tarball, E2E jobs now only download tarballs.The E2E scripts are now plain
.mjsfiles without dependencies. They run under each app's pinned Node (down to 20.19), which rules out Node's type stripping. Withrun.tsconverted too, the package no longer needstsx,dotenv,glob,esbuildor a tsconfig (lint:tsnever ran in CI).Since #25380 the Playwright install reads its version from the app's
package.json, so it doesn't need the rootnode_moduleseither. Since #25334,install-pnpmtakes pnpm from the rootnode_modulestoo, so the E2E jobs install the rootdevDependenciesversion withpnpm/action-setupinstead. Other workflows and local runs keep getting pnpm throughyarn.lock.aws-serverlessstill downloads the build output, since its Lambda stack installs the built package directories.Stacked on #25402. Replaces #25371, which GitHub closed as merged by accident during a restack. Its review history is still there.
🤖 Generated with Claude Code