Repository navigation
Conversation
…sform
The transform rewrote `export { default } from './handler'` to bind the
wrapped handler with a `const`. A module in an import cycle that read
the entry's default export during evaluation hit the `const` before
its initialization, threw a `ReferenceError`, and stopped the Worker
from starting.
The binding is now a `var`, as `wrapDefaultSpecifier` and
`wrapDefaultExport` already use. A cyclic read gets `undefined` and
does not throw. It does not get the handler as the original live
binding did, because the wrapper is not set until the entry's body
runs. The JSDoc states this limit.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
requested review from
andreiborza and
mydea
and removed request for
a team
October 22, 2026 17:27
Member
Author
|
Note: this is an application of the same fix landed in #25372, but for a default re-export, which I overlooked in the previous PR. |
Contributor
size-limit report 📦Compared: a5560d8 (PR test merge using develop at 40eff80) Against: 40eff80 (develop) · base run #63186 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 32 successful. See the run. Successful checks
|
mydea
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transform rewrote
export { default } from './handler'to bind the wrapped handler with aconst. A module in an import cycle that read the entry's default export during evaluation hit theconstbefore its initialization, threw aReferenceError, and stopped the Worker from starting.The binding is now a
var, aswrapDefaultSpecifierandwrapDefaultExportalready use. A cyclic read getsundefinedand does not throw. It does not get the handler as the original live binding did, because the wrapper is not set until the entry's body runs. The JSDoc states this limit.