Add agentic onboarding progress polling - #121915
Draft
evanpurkhiser wants to merge 1 commit into
Draft
Conversation
Contributor
Sentry Snapshot Testing
|
evanpurkhiser
force-pushed
the
agentic-onboarding-polling
branch
from
August 13, 2026 01:09
99afdfc to
f64032d
Compare
evanpurkhiser
force-pushed
the
agentic-onboarding-polling
branch
from
August 13, 2026 01:23
b899148 to
c5c8892
Compare
Add the browser fallback for reading a complete onboarding snapshot by run ID. The same endpoint lets the browser cancel an active run while preserving the final state for rendering. Reads and cancellation enforce the original user and organization ownership boundary.
evanpurkhiser
force-pushed
the
agentic-onboarding-polling
branch
from
August 13, 2026 01:26
c5c8892 to
7e74423
Compare
Comment on lines
+51
to
+52
| except ValueError: | ||
| return Response({"detail": CANNOT_CANCEL_RUN_DETAIL}, status=400) |
Contributor
There was a problem hiding this comment.
Delete endpoint catches broad ValueError from deserialization failures
The broad except ValueError in delete() catches InvalidOnboardingRun from corrupt or incompatible Redis snapshots and returns a misleading terminal-run message instead of the actual error.
Evidence
cancel()inOnboardingProgressServiceraisesValueError("Onboarding run is terminal")only whenrun_statusis notACTIVE._atomic_update()calls_deserialize()first, which invokesOnboardingRun.from_dict(). Any schema mismatch or corrupt data raisesInvalidOnboardingRun, which inherits fromValueError.- The
delete()handler catches allValueErrorwithCANNOT_CANCEL_RUN_DETAIL, so a deserialization failure is reported as "cannot be cancelled after it is terminal" instead of the actual data error. - The
get()endpoint on the same service does not guardValueErrorfrom_deserialize, causing a 500 on malformed snapshots.
Identified by Warden · sentry-backend-bugs · DRG-BH3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4 of 5. Previous: #121914. Next: #121916
Add the browser fallback for reading a complete onboarding snapshot by run ID. The same endpoint lets the browser cancel an active run while preserving the final state for rendering.
Reads and cancellation enforce the original user and organization ownership boundary.