Skip to content

ref(charts): Rename MarkLine utility to markLine for convention adherence - #121930

Merged
ryan953 merged 3 commits into
masterfrom
seer/ref-markline-rename
Aug 13, 2026
Merged

ref(charts): Rename MarkLine utility to markLine for convention adherence#121930
ryan953 merged 3 commits into
masterfrom
seer/ref-markline-rename

Conversation

@sentry

@sentry sentry Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR renames the MarkLine utility function to markLine (camelCase) in static/app/components/charts/components/markLine.tsx and updates all its import and call sites across the codebase.

The change addresses the CODING-CONVENTIONS-1NY issue, which flagged MarkLine as a violation of the no-capitalized-function-calls ESLint rule. This rule reserves capitalized function names for React components, whereas MarkLine is a plain utility function that returns an eCharts configuration object, not a React component. Renaming it to markLine aligns it with the project's coding conventions.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Consolidated: also fixes the same MarkLine -> markLine violation flagged by 4 duplicate issues in this file cluster (superseded PRs #121931, #121932, #121933, #121934 closed as duplicates).

Fixes CODING-CONVENTIONS-1NY
Fixes CODING-CONVENTIONS-1P5
Fixes CODING-CONVENTIONS-1PW
Fixes CODING-CONVENTIONS-1TQ
Fixes CODING-CONVENTIONS-1WS

The MarkLine -> markLine rename missed a type reference in releaseSeries.tsx and two gsApp call sites (spikeProtectionUsageChart, reservedUsageChart) that still imported and called the old capitalized export, breaking typecheck.
@ryan953
ryan953 requested a review from a team as a code owner August 13, 2026 04:59
@github-actions github-actions Bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Aug 13, 2026
The map callback parameter reused the name markLine, shadowing the top-level markLine factory import introduced by the MarkLine -> markLine rename and tripping @typescript-eslint/no-shadow.
@github-actions

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 94.34% 94.34% ±0%
Typed 133,981 133,981 ±0
Untyped 8,043 8,043 ±0
🔍 1 new type safety issue introduced

Type assertions (as) (1 new)

File Line Detail
static/app/views/dashboards/widgets/timeSeriesWidget/plottables/thresholds.tsx 234 as stringmarkLineOption?.lineStyle?.color as string

This is informational only and does not block the PR.

@TkDodo TkDodo added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Aug 13, 2026
@ryan953
ryan953 merged commit 6c50865 into master Aug 13, 2026
90 of 91 checks passed
@ryan953
ryan953 deleted the seer/ref-markline-rename branch August 13, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants