ref(charts): Rename MarkLine utility to markLine for convention adherence - #121930
Merged
Conversation
This was referenced Aug 13, 2026
The MarkLine -> markLine rename missed a type reference in releaseSeries.tsx and two gsApp call sites (spikeProtectionUsageChart, reservedUsageChart) that still imported and called the old capitalized export, breaking typecheck.
The map callback parameter reused the name markLine, shadowing the top-level markLine factory import introduced by the MarkLine -> markLine rename and tripping @typescript-eslint/no-shadow.
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
TkDodo
approved these changes
Aug 13, 2026
ryan953
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
MarkLineutility function tomarkLine(camelCase) instatic/app/components/charts/components/markLine.tsxand updates all its import and call sites across the codebase.The change addresses the
CODING-CONVENTIONS-1NYissue, which flaggedMarkLineas a violation of theno-capitalized-function-callsESLint rule. This rule reserves capitalized function names for React components, whereasMarkLineis a plain utility function that returns an eCharts configuration object, not a React component. Renaming it tomarkLinealigns it with the project's coding conventions.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Consolidated: also fixes the same
MarkLine->markLineviolation flagged by 4 duplicate issues in this file cluster (superseded PRs #121931, #121932, #121933, #121934 closed as duplicates).Fixes CODING-CONVENTIONS-1NY
Fixes CODING-CONVENTIONS-1P5
Fixes CODING-CONVENTIONS-1PW
Fixes CODING-CONVENTIONS-1TQ
Fixes CODING-CONVENTIONS-1WS