Skip to content

ref(markLine): Rename MarkLine factory to markLine to fix linting - #121932

Closed
sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/no-capitalized-function-calls-markline
Closed

ref(markLine): Rename MarkLine factory to markLine to fix linting#121932
sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/no-capitalized-function-calls-markline

Conversation

@sentry

@sentry sentry Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR renames the MarkLine factory function to markLine in static/app/components/charts/components/markLine.tsx.

The previous naming convention used a capitalized identifier (MarkLine) for a plain factory function call, which violated the no-capitalized-function-calls linting rule. This rule reserves capitalized names for React components (used as JSX) or class constructors.

All import statements and call sites across the codebase that used MarkLine(...) have been updated to markLine(...). In some instances, local variables named markLine were renamed to markLineSeries to avoid shadowing the newly imported markLine function.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes CODING-CONVENTIONS-1TQ

@sentry
sentry Bot requested review from a team as code owners August 13, 2026 01:46
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 13, 2026
@ryan953

ryan953 commented Aug 13, 2026

Copy link
Copy Markdown
Member

Closing as a duplicate — this same MarkLine -> markLine rename is consolidated in #121930, which now also references this issue's Sentry ticket so merging it will close it too.

@ryan953 ryan953 closed this Aug 13, 2026
ryan953 added a commit that referenced this pull request Aug 13, 2026
…ence (#121930)

This PR renames the `MarkLine` utility function to `markLine`
(camelCase) in `static/app/components/charts/components/markLine.tsx`
and updates all its import and call sites across the codebase.

The change addresses the `CODING-CONVENTIONS-1NY` issue, which flagged
`MarkLine` as a violation of the `no-capitalized-function-calls` ESLint
rule. This rule reserves capitalized function names for React
components, whereas `MarkLine` is a plain utility function that returns
an eCharts configuration object, not a React component. Renaming it to
`markLine` aligns it with the project's coding conventions.

<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---
_Consolidated: also fixes the same `MarkLine` -> `markLine` violation
flagged by 4 duplicate issues in this file cluster (superseded PRs
#121931, #121932, #121933, #121934 closed as duplicates)._

Fixes
[CODING-CONVENTIONS-1NY](https://sentry.sentry.io/issues/7619788226/?seerDrawer=true)
Fixes
[CODING-CONVENTIONS-1P5](https://sentry.sentry.io/issues/7619788237/?seerDrawer=true)
Fixes
[CODING-CONVENTIONS-1PW](https://sentry.sentry.io/issues/7619788267/?seerDrawer=true)
Fixes
[CODING-CONVENTIONS-1TQ](https://sentry.sentry.io/issues/7619788410/?seerDrawer=true)
Fixes
[CODING-CONVENTIONS-1WS](https://sentry.sentry.io/issues/7619788484/?seerDrawer=true)

---------

Co-authored-by: Ryan Albrecht <ryan953@users.noreply.github.com>
Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant