ref(markLine): Rename MarkLine factory to markLine to fix linting - #121932
Closed
sentry[bot] wants to merge 1 commit into
Closed
ref(markLine): Rename MarkLine factory to markLine to fix linting#121932sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Member
|
Closing as a duplicate — this same |
ryan953
added a commit
that referenced
this pull request
Aug 13, 2026
…ence (#121930) This PR renames the `MarkLine` utility function to `markLine` (camelCase) in `static/app/components/charts/components/markLine.tsx` and updates all its import and call sites across the codebase. The change addresses the `CODING-CONVENTIONS-1NY` issue, which flagged `MarkLine` as a violation of the `no-capitalized-function-calls` ESLint rule. This rule reserves capitalized function names for React components, whereas `MarkLine` is a plain utility function that returns an eCharts configuration object, not a React component. Renaming it to `markLine` aligns it with the project's coding conventions. <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --- _Consolidated: also fixes the same `MarkLine` -> `markLine` violation flagged by 4 duplicate issues in this file cluster (superseded PRs #121931, #121932, #121933, #121934 closed as duplicates)._ Fixes [CODING-CONVENTIONS-1NY](https://sentry.sentry.io/issues/7619788226/?seerDrawer=true) Fixes [CODING-CONVENTIONS-1P5](https://sentry.sentry.io/issues/7619788237/?seerDrawer=true) Fixes [CODING-CONVENTIONS-1PW](https://sentry.sentry.io/issues/7619788267/?seerDrawer=true) Fixes [CODING-CONVENTIONS-1TQ](https://sentry.sentry.io/issues/7619788410/?seerDrawer=true) Fixes [CODING-CONVENTIONS-1WS](https://sentry.sentry.io/issues/7619788484/?seerDrawer=true) --------- Co-authored-by: Ryan Albrecht <ryan953@users.noreply.github.com> Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
MarkLinefactory function tomarkLineinstatic/app/components/charts/components/markLine.tsx.The previous naming convention used a capitalized identifier (
MarkLine) for a plain factory function call, which violated theno-capitalized-function-callslinting rule. This rule reserves capitalized names for React components (used as JSX) or class constructors.All import statements and call sites across the codebase that used
MarkLine(...)have been updated tomarkLine(...). In some instances, local variables namedmarkLinewere renamed tomarkLineSeriesto avoid shadowing the newly importedmarkLinefunction.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-1TQ