fix(workerchild): ignore empty producer future sets - #766
Merged
Conversation
bmckerry
approved these changes
Jul 24, 2026
3 tasks
lvthanh03
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 27, 2026
) Rolls backpressure out to FutureTrackingProducer after the previous attempt in #120470 and after a bug fix was made: getsentry/taskbroker#766. Adds an option to enable FTP backpressure, this will require producers to restart after the option changes to take effect. Updates existing FTP instances to use this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arroyo’s
FutureTrackingProducer.collect_futures()retains producer keys after clearing their queues. Taskbroker therefore treated mappings containing only empty sets as pending future work, routing subsequent tasks through the asynchronous future-completion path.We want to check the collected sets instead of the mapping length.