Skip to content

fix(workerchild): ignore empty producer future sets #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvthanh03 merged 1 commit into from
Jul 27, 2026
Merged

fix(workerchild): ignore empty producer future sets #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/python/src/taskbroker_client/worker/workerchild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ def check_task_future_completion(
if next_state != TASK_ACTIVATION_STATUS_COMPLETE:
task_produced_futures = {}

if len(task_produced_futures) == 0:
if not any(task_produced_futures.values()):
_task_execution_complete(
inflight,
next_state,
Expand Down
36 changes: 36 additions & 0 deletions clients/python/tests/worker/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1972,6 +1972,42 @@ def test_child_process_tracks_producer_futures(
assert result.status == TASK_ACTIVATION_STATUS_COMPLETE


@pytest.mark.parametrize("producer_cls", _PRODUCER_CLASSES)
def test_child_process_ignores_empty_producer_future_sets(
producer_cls: type,
clear_pending_futures: None,
restore_signal_handlers: None,
) -> None:
task = _producing_task()
todo: queue.Queue[InflightTaskActivation] = queue.Queue()
processed: queue.Queue[ProcessingResult] = queue.Queue()
shutdown = Event()

todo.put(task)
with (
mock.patch.object(producer_cls, "collect_futures", return_value={"test.producer": set()}),
mock.patch(
"taskbroker_client.worker.workerchild.ActivationWithPendingFutures"
) as pending_task,
):
child_process(
"examples.app:app",
todo,
processed,
shutdown,
max_task_count=1,
processing_pool_name="test",
process_type="fork",
skip_awaiting_futures=False,
future_checking_frequency=0.1,
)

pending_task.assert_not_called()
result = processed.get(timeout=5)
assert result.task_id == task.activation.id
assert result.status == TASK_ACTIVATION_STATUS_COMPLETE


@pytest.mark.parametrize("producer_cls", _PRODUCER_CLASSES)
def test_child_process_holds_result_until_futures_done(
producer_cls: type,
Expand Down
Loading