Repository navigation
[ca] chore: update Claude Code CLI to 2.1.318 - #75838
github-actions[bot] wants to merge 1 commit into
Conversation
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
I found one blocking consistency issue: the checked-in workflow lock files still reference Claude Code 2.1.317, so this constant-only bump does not affect existing compiled workflows and leaves the repository in drift. Please regenerate and include the lock updates with the version pin. The matching test update is otherwise consistent.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K
Comment /review to run again
|
|
||
| // DefaultClaudeCodeVersion is the default version of the Claude Code CLI. | ||
| const DefaultClaudeCodeVersion Version = "2.1.317" | ||
| const DefaultClaudeCodeVersion Version = "2.1.318" |
There was a problem hiding this comment.
This pin bump also requires regenerating and committing the checked-in .lock.yml workflows. The current lock files still embed 2.1.317 (781 matches across 65 files), so merged workflows continue installing/reporting the old CLI and the repository becomes inconsistent until a later recompile. Please include the generated lock updates, or otherwise ensure the merge updates them atomically with this constant.
There was a problem hiding this comment.
🟢 Approval recommended
The default Claude Code version constant and its corresponding test expectation are synchronized, with no active review issues identified.
No open issues 🎉
What changed in this PR
Updates the default Claude Code CLI pin from 2.1.317 to 2.1.318 and synchronizes the corresponding constants test. No workflow source or generated lock files were changed.
Changes:
- Updated
DefaultClaudeCodeVersionto2.1.318. - Updated the expected version in the existing constants test.
| File | Description |
|---|---|
pkg/constants/version_constants.go |
Defines the updated default Claude Code CLI version. |
pkg/constants/version_constants_test.go |
Verifies the updated default version pin. |
Review effort: Lite (auto)
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /diagnosing-bugs and /tdd. Requesting changes because the pin bump leaves the 362 committed workflow lock files on 2.1.317, so the change is inert and CI drift check will fail.
📋 Key Themes & Highlights
Key Themes
- Stale generated artifacts:
GH_AW_INFO_VERSIONin 65.lock.ymlfiles still reads 2.1.317. Recompiling one file on this branch changed 12 lines. - CI gate: the
Check workflow markdown/lock driftjob inci.ymlfails on any lock diff. - Test gap:
TestDefaultCLIMCPVersionscannot detect lock drift.
Verification
go test ./pkg/constants -run TestDefaultCLIMCPVersionspasses.- Full drift script run timed out in this environment, so the failure is confirmed by compiling one workflow, not the full set.
Positive Highlights
- ✅ The constant and its test literal are updated together.
- ✅ The PR documents the cooldown check and npm integrity hash.
@copilot please address the review comments above.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~3 AIC · ⌖ ~2 AIC · ⊞ 5.4K
Comment /matt to run again
| want Version | ||
| }{ | ||
| {"Claude Code", DefaultClaudeCodeVersion, "2.1.317"}, | ||
| {"Claude Code", DefaultClaudeCodeVersion, "2.1.318"}, |
There was a problem hiding this comment.
[/tdd] This test passes even while the lock files pin the old version, so it cannot catch the drift above. It only checks the constant against a duplicate literal.
💡 Suggested coverage
Keep this assertion. Consider adding a test that reads the committed .github/workflows/*.lock.yml files and asserts each GH_AW_INFO_VERSION for Claude matches DefaultClaudeCodeVersion. That would fail on this PR and prevent future pin bumps from landing without a recompile.
@copilot please address this.
|
|
||
| // DefaultClaudeCodeVersion is the default version of the Claude Code CLI. | ||
| const DefaultClaudeCodeVersion Version = "2.1.317" | ||
| const DefaultClaudeCodeVersion Version = "2.1.318" |
There was a problem hiding this comment.
[/diagnosing-bugs] This pin bump does not take effect yet, and CI will fail. The committed .lock.yml files still embed GH_AW_INFO_VERSION: "2.1.317" (65 files). Recompiling agent-job-health on this branch changes 12 lines to 2.1.318, and the Check workflow markdown/lock drift job in ci.yml fails on any lock diff.
💡 Fix
Run make recompile after this pin change, commit the regenerated .github/workflows/*.lock.yml files, then confirm bash scripts/check-workflow-drift.sh ./gh-aw exits 0. The PR body says the lock changes were restored and excluded, so they need to be included here.
@copilot please address this.
Summary
Update the default Claude Code CLI pin from 2.1.317 to 2.1.318. The matching version expectation in
pkg/constants/version_constants_test.gois updated so the pin remains covered by the existing test.Evidence and selection
sha512-OTJgLxcvWefv8IdTsq5n90Z2IxEhLwKqHUBhwZYE4odXzKA/Tb6p2Zb5Iy9Vq7JIVcNZzn9cPxW5sb42wLF95Q==.Open pull-request and issue searches found no active PR covering this Claude Code update. The only matching open PR was unrelated (#74077).
Release assessment
CLI validation
Installed
@anthropic-ai/claude-code@2.1.318in disposable/tmp/gh-aw/agent/cli-version-checker/claude-2.1.318storage. The installed CLI reported2.1.318 (Claude Code)and its main--helpcommand completed successfully.Repository validation
go test ./pkg/constants— passed.make recompile— passed; 362 workflows compiled.git diff --check— passed.make fmt— Go formatting completed, but the overall target exited nonzero because the repository-local JavaScript Prettier binary is missing (actions/setup/js/node_modules/.bin/prettier). No JavaScript files were changed.go test ./pkg/cli— attempted but failed in existing environment-dependent tests because/home/runner/work/_tempdeniedmktempallocation; the failure was unrelated to this constants-only change.Generated workflow lock changes were restored and are not part of this PR. No workflow source files were changed.