Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/constants/version_constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (v Version) IsValid() bool {
type ModelName string

// DefaultClaudeCodeVersion is the default version of the Claude Code CLI.
const DefaultClaudeCodeVersion Version = "2.1.317"
const DefaultClaudeCodeVersion Version = "2.1.318"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin bump also requires regenerating and committing the checked-in .lock.yml workflows. The current lock files still embed 2.1.317 (781 matches across 65 files), so merged workflows continue installing/reporting the old CLI and the repository becomes inconsistent until a later recompile. Please include the generated lock updates, or otherwise ensure the merge updates them atomically with this constant.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/diagnosing-bugs] This pin bump does not take effect yet, and CI will fail. The committed .lock.yml files still embed GH_AW_INFO_VERSION: "2.1.317" (65 files). Recompiling agent-job-health on this branch changes 12 lines to 2.1.318, and the Check workflow markdown/lock drift job in ci.yml fails on any lock diff.

💡 Fix

Run make recompile after this pin change, commit the regenerated .github/workflows/*.lock.yml files, then confirm bash scripts/check-workflow-drift.sh ./gh-aw exits 0. The PR body says the lock changes were restored and excluded, so they need to be included here.

@copilot please address this.


// DefaultCopilotVersion is the default version of the GitHub Copilot CLI.
//
Expand Down
2 changes: 1 addition & 1 deletion pkg/constants/version_constants_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func TestDefaultCLIMCPVersions(t *testing.T) {
got Version
want Version
}{
{"Claude Code", DefaultClaudeCodeVersion, "2.1.317"},
{"Claude Code", DefaultClaudeCodeVersion, "2.1.318"},

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/tdd] This test passes even while the lock files pin the old version, so it cannot catch the drift above. It only checks the constant against a duplicate literal.

💡 Suggested coverage

Keep this assertion. Consider adding a test that reads the committed .github/workflows/*.lock.yml files and asserts each GH_AW_INFO_VERSION for Claude matches DefaultClaudeCodeVersion. That would fail on this PR and prevent future pin bumps from landing without a recompile.

@copilot please address this.

{"Copilot CLI", DefaultCopilotVersion, "1.0.103"},
{"Copilot SDK", DefaultCopilotSDKVersion, "1.0.16"},
{"Codex", DefaultCodexVersion, "0.166.0"},
Expand Down
Loading